Changeset 62228 in webkit


Ignore:
Timestamp:
Jun 30, 2010 11:07:30 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-06-30 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Crash when uploading document to Google Docs
​https://bugs.webkit.org/show_bug.cgi?id=40795

Fix bug where the local file wasn't opened (for POSTing)
if it were the first element in the form.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::FormDataIODevice::moveToNextElement): (WebCore::FormDataIODevice::openFileForCurrentElement):
  • platform/network/qt/QNetworkReplyHandler.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r62227 r62228  
     12010-06-30  Andreas Kling  <andreas.kling@nokia.com>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        [Qt] Crash when uploading document to Google Docs
     6        https://bugs.webkit.org/show_bug.cgi?id=40795
     7
     8        Fix bug where the local file wasn't opened (for POSTing)
     9        if it were the first element in the form.
     10
     11        * platform/network/qt/QNetworkReplyHandler.cpp:
     12        (WebCore::FormDataIODevice::FormDataIODevice):
     13        (WebCore::FormDataIODevice::moveToNextElement):
     14        (WebCore::FormDataIODevice::openFileForCurrentElement):
     15        * platform/network/qt/QNetworkReplyHandler.h:
     16
    1172010-06-30  Eric Seidel  <eric@webkit.org>
    218

  • trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp

    r61875 r62228  
    6161{
    6262    setOpenMode(FormDataIODevice::ReadOnly);
     63
     64    if (!m_formElements.isEmpty() && m_formElements[0].m_type == FormDataElement::encodedFile)
     65        openFileForCurrentElement();
    6366}
    6467
    … …  
    7982        return;
    8083
     84    openFileForCurrentElement();
     85}
     86
     87void FormDataIODevice::openFileForCurrentElement()
     88{
    8189    if (!m_currentFile)
    8290        m_currentFile = new QFile;

  • trunk/WebCore/platform/network/qt/QNetworkReplyHandler.h

    r61663 r62228  
    105105private:
    106106    void moveToNextElement();
     107    void openFileForCurrentElement();
    107108
    108109private:
Note: See TracChangeset for help on using the changeset viewer.