Changeset 62298 in webkit

Timestamp:

Jul 1, 2010 2:02:55 PM (14 years ago)

Author:

vestbo@webkit.org

Message:

[Qt] Make context menus show up in the right place in QTestBrowser

Reviewed by Kenneth Rohde Christiansen.

Context menus were shown at scene-relative coordinates for
QGraphicsWebView while QMenu expects them to be global. The
change to the QWidget case was to get rid of the mapToGlobal.

• QtTestBrowser/webview.cpp:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• QtTestBrowser/webview.cpp (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Make context menus show up in the right place in QTestBrowser
+
+        Context menus were shown at scene-relative coordinates for
+        QGraphicsWebView while QMenu expects them to be global. The
+        change to the QWidget case was to get rid of the mapToGlobal.
+
+        * QtTestBrowser/webview.cpp:
+
 2010-07-01  Robert Hogan <robert@webkit.org>
 

trunk/WebKitTools/QtTestBrowser/webview.cpp

@@ -193 +193 @@
 {
     QMenu* menu = createContextMenu(page(), event->pos().toPoint());
-    menu->exec(mapToScene(event->pos()).toPoint());
+    menu->exec(event->screenPos());
     delete menu;
 }
@@ -200 +200 @@
 {
     QMenu* menu = createContextMenu(page(), event->pos());
-    menu->exec(mapToGlobal(event->pos()));
+    menu->exec(event->globalPos());
     delete menu;
 }