Changeset 62349 in webkit


Ignore:
Timestamp:
Jul 1, 2010 7:50:38 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-01 David Holloway <​dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
use by other code in WebKit/chromium/src.

Specific use of these methods is made in WebFrameImpl.cpp. This is
preferred to the cast operator call that was happening prior to this
change.

​https://bugs.webkit.org/show_bug.cgi?id=41477

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
Location:
trunk/WebKit/chromium
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/chromium/ChangeLog

    r62288 r62349  
     12010-07-01  David Holloway  <dhollowa@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
     6        use by other code in WebKit/chromium/src.
     7
     8        Specific use of these methods is made in WebFrameImpl.cpp.  This is
     9        preferred to the cast operator call that was happening prior to this
     10        change.
     11
     12        https://bugs.webkit.org/show_bug.cgi?id=41477
     13
     14        * public/WebNode.h:
     15        * src/WebFrameImpl.cpp:
     16        (WebKit::WebFrameImpl::registerPasswordListener):
     17        (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
     18
    1192010-07-01  Kenneth Russell  <kbr@google.com>
    220

  • trunk/WebKit/chromium/public/WebNode.h

    r58967 r62349  
    125125#endif
    126126
    127 protected:
    128127#if WEBKIT_IMPLEMENTATION
    129128    template<typename T> T* unwrap()
    … …  
    138137#endif
    139138
     139protected:
    140140    WebPrivatePtr<WebCore::Node> m_private;
    141141};

  • trunk/WebKit/chromium/src/WebFrameImpl.cpp

    r62272 r62349  
    19611961    WebPasswordAutocompleteListener* listener)
    19621962{
    1963     RefPtr<HTMLInputElement> element = inputElement.operator PassRefPtr<HTMLInputElement>();
     1963    RefPtr<HTMLInputElement> element(inputElement.unwrap<HTMLInputElement>());
    19641964    if (!m_passwordListeners.add(element, listener).second) {
    19651965        delete listener;
    … …  
    19721972    const WebInputElement& inputElement)
    19731973{
    1974     RefPtr<HTMLInputElement> element = inputElement.operator PassRefPtr<HTMLInputElement>();
     1974    RefPtr<HTMLInputElement> element(inputElement.unwrap<HTMLInputElement>());
    19751975    WebPasswordAutocompleteListener* listener = getPasswordListener(element.get());
    19761976    // Password listeners need to autocomplete other fields that depend on the
Note: See TracChangeset for help on using the changeset viewer.