Changeset 62440 in webkit


Ignore:
Timestamp:
Jul 3, 2010 12:17:39 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-07-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41560

It's somewhat hard to observe this state, so I'm not surprised that the
diff to the expected results are small. We still fail this test
because we don't handle whitespace correctly.

  • html5lib/runner-expected-html5.txt:

2010-07-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41560

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62439 r62440  
     12010-07-03  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Implement AfterFramesetMode
     6        https://bugs.webkit.org/show_bug.cgi?id=41560
     7
     8        It's somewhat hard to observe this state, so I'm not surprised that the
     9        diff to the expected results are small.  We still fail this test
     10        because we don't handle whitespace correctly.
     11
     12        * html5lib/runner-expected-html5.txt:
     13
    1142010-07-02  Adam Barth  <abarth@webkit.org>
    215

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62439 r62440  
    21392139|   <head>
    21402140|   <frameset>
     2141|   <noframes>
    21412142Expected:
    21422143| <html>

  • trunk/WebCore/ChangeLog

    r62439 r62440  
     12010-07-03  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Implement AfterFramesetMode
     6        https://bugs.webkit.org/show_bug.cgi?id=41560
     7
     8        * html/HTMLTreeBuilder.cpp:
     9        (WebCore::HTMLTreeBuilder::processStartTag):
     10        (WebCore::HTMLTreeBuilder::processEndTag):
     11        (WebCore::HTMLTreeBuilder::processCharacter):
     12        (WebCore::HTMLTreeBuilder::processEndOfFile):
     13
    1142010-07-02  Adam Barth  <abarth@webkit.org>
    215

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62439 r62440  
    645645        parseError(token);
    646646        break;
     647    case AfterFramesetMode:
     648        ASSERT(insertionMode() == AfterFramesetMode);
     649        if (token.name() == htmlTag) {
     650            insertHTMLStartTagInBody(token);
     651            return;
     652        }
     653        if (token.name() == noframesTag) {
     654            processStartTagForInHead(token);
     655            return;
     656        }
     657        parseError(token);
     658        break;
    647659    default:
    648660        notImplemented();
    … …  
    885897        }
    886898        break;
     899    case AfterFramesetMode:
     900        ASSERT(insertionMode() == AfterFramesetMode);
     901        if (token.name() == htmlTag) {
     902            m_insertionMode = AfterAfterFramesetMode;
     903            return;
     904        }
     905        parseError(token);
     906        break;
    887907    default:
    888908        notImplemented();
    … …  
    954974        break;
    955975    case InFramesetMode:
    956         ASSERT(insertionMode() == InFramesetMode);
     976    case AfterFramesetMode:
     977        ASSERT(insertionMode() == InFramesetMode || insertionMode() == AfterFramesetMode);
    957978        parseError(token);
    958979        break;
    … …  
    10031024        if (currentElement() != m_openElements.htmlElement())
    10041025            parseError(token);
     1026        break;
     1027    case AfterFramesetMode:
     1028        ASSERT(insertionMode() == AfterFramesetMode);
    10051029        break;
    10061030    default:
Note: See TracChangeset for help on using the changeset viewer.