Changeset 62598 in webkit


Ignore:
Timestamp:
Jul 6, 2010 3:32:21 PM (14 years ago)
Author:
kov@webkit.org
Message:

2010-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Scrollbars sometimes go dead and stop scrolling the view
https://bugs.webkit.org/show_bug.cgi?id=41711

Fixes GtkScrolledWindow scrollbars not actually scrolling the page
in certain conditions. No tests because it is hard to reproduce,
and depends on interaction with a widget that is outside of the
WebView, which is tricky.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r62596 r62598  
     12010-07-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] Scrollbars sometimes go dead and stop scrolling the view
     6        https://bugs.webkit.org/show_bug.cgi?id=41711
     7
     8        Fixes GtkScrolledWindow scrollbars not actually scrolling the page
     9        in certain conditions. No tests because it is hard to reproduce,
     10        and depends on interaction with a widget that is outside of the
     11        WebView, which is tricky.
     12
     13        * platform/gtk/ScrollViewGtk.cpp:
     14        (WebCore::ScrollView::setGtkAdjustments):
     15
    1162010-07-06  Darin Adler  <darin@apple.com>
    217
  • trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

    r62014 r62598  
    109109    // Reset the adjustments to a sane default
    110110    if (m_horizontalAdjustment) {
     111        // We may be lacking scrollbars when returning to a cached
     112        // page, this kicks the page to recreate the scrollbars.
     113        setHasVerticalScrollbar(true);
     114        setHasHorizontalScrollbar(true);
     115
    111116        ScrollbarGtk* hScrollbar = reinterpret_cast<ScrollbarGtk*>(horizontalScrollbar());
    112         if (hScrollbar)
    113             hScrollbar->attachAdjustment(m_horizontalAdjustment);
     117        hScrollbar->attachAdjustment(m_horizontalAdjustment);
    114118
    115119        ScrollbarGtk* vScrollbar = reinterpret_cast<ScrollbarGtk*>(verticalScrollbar());
    116         if (vScrollbar)
    117             vScrollbar->attachAdjustment(m_verticalAdjustment);
     120        vScrollbar->attachAdjustment(m_verticalAdjustment);
    118121
    119122        // We used to reset everything to 0 here, but when page cache
Note: See TracChangeset for help on using the changeset viewer.