Changeset 62656 in webkit


Ignore:
Timestamp:
Jul 7, 2010 6:01:31 AM (14 years ago)
Author:
loislo@chromium.org
Message:

2010-07-07 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: All RefPtr arguments and return values should be
changed to PassRefPtr whenever it is possible according to common practice.
​https://bugs.webkit.org/show_bug.cgi?id=41759

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createGCEventData): (WebCore::TimelineRecordFactory::createFunctionCallData): (WebCore::TimelineRecordFactory::createEventDispatchData): (WebCore::TimelineRecordFactory::createGenericTimerData): (WebCore::TimelineRecordFactory::createTimerInstallData): (WebCore::TimelineRecordFactory::createXHRReadyStateChangeData): (WebCore::TimelineRecordFactory::createXHRLoadData): (WebCore::TimelineRecordFactory::createEvaluateScriptData): (WebCore::TimelineRecordFactory::createMarkTimelineData): (WebCore::TimelineRecordFactory::createScheduleResourceRequestData): (WebCore::TimelineRecordFactory::createResourceSendRequestData): (WebCore::TimelineRecordFactory::createResourceReceiveResponseData): (WebCore::TimelineRecordFactory::createResourceFinishData): (WebCore::TimelineRecordFactory::createReceiveResourceData): (WebCore::TimelineRecordFactory::createPaintData): (WebCore::TimelineRecordFactory::createParseHTMLData):
  • inspector/TimelineRecordFactory.h:
Location:
trunk/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r62654 r62656  
     12010-07-07  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: All RefPtr arguments and return values should be
     6        changed to PassRefPtr whenever it is possible according to common practice.
     7        https://bugs.webkit.org/show_bug.cgi?id=41759
     8
     9        * inspector/CodeGeneratorInspector.pm:
     10        * inspector/InspectorTimelineAgent.cpp:
     11        (WebCore::InspectorTimelineAgent::pushGCEventRecords):
     12        (WebCore::InspectorTimelineAgent::didInstallTimer):
     13        (WebCore::InspectorTimelineAgent::didRemoveTimer):
     14        (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
     15        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
     16        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
     17        (WebCore::InspectorTimelineAgent::didMarkTimeline):
     18        (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
     19        (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
     20        (WebCore::InspectorTimelineAgent::addRecordToTimeline):
     21        (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
     22        (WebCore::InspectorTimelineAgent::pushCurrentRecord):
     23        * inspector/InspectorTimelineAgent.h:
     24        (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
     25        * inspector/TimelineRecordFactory.cpp:
     26        (WebCore::TimelineRecordFactory::createGenericRecord):
     27        (WebCore::TimelineRecordFactory::createGCEventData):
     28        (WebCore::TimelineRecordFactory::createFunctionCallData):
     29        (WebCore::TimelineRecordFactory::createEventDispatchData):
     30        (WebCore::TimelineRecordFactory::createGenericTimerData):
     31        (WebCore::TimelineRecordFactory::createTimerInstallData):
     32        (WebCore::TimelineRecordFactory::createXHRReadyStateChangeData):
     33        (WebCore::TimelineRecordFactory::createXHRLoadData):
     34        (WebCore::TimelineRecordFactory::createEvaluateScriptData):
     35        (WebCore::TimelineRecordFactory::createMarkTimelineData):
     36        (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
     37        (WebCore::TimelineRecordFactory::createResourceSendRequestData):
     38        (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
     39        (WebCore::TimelineRecordFactory::createResourceFinishData):
     40        (WebCore::TimelineRecordFactory::createReceiveResourceData):
     41        (WebCore::TimelineRecordFactory::createPaintData):
     42        (WebCore::TimelineRecordFactory::createParseHTMLData):
     43        * inspector/TimelineRecordFactory.h:
     44
    1452010-07-07  Antti Koivisto  <koivisto@iki.fi>
    246

  • trunk/WebCore/inspector/CodeGeneratorInspector.pm

    r62549 r62656  
    1414    "header" => "InspectorClient.h",
    1515};
    16 $typeTransform{"RefPtr"} = {
    17     "forwardHeader" => "wtf/RefPtr.h",
     16$typeTransform{"PassRefPtr"} = {
     17    "forwardHeader" => "wtf/PassRefPtr.h",
    1818};
    1919$typeTransform{"Object"} = {
    20     "param" => "const RefPtr<InspectorObject>&",
     20    "param" => "PassRefPtr<InspectorObject>",
    2121    "retVal" => "PassRefPtr<InspectorObject>",
    2222    "forward" => "InspectorObject",
    … …  
    2525};
    2626$typeTransform{"Array"} = {
    27     "param" => "const RefPtr<InspectorArray>&",
     27    "param" => "PassRefPtr<InspectorArray>",
    2828    "retVal" => "PassRefPtr<InspectorArray>",
    2929    "forward" => "InspectorArray",
    … …  
    141141    $discoveredTypes{"String"} = 1;
    142142    $discoveredTypes{"InspectorClient"} = 1;
    143     $discoveredTypes{"RefPtr"} = 1;
     143    $discoveredTypes{"PassRefPtr"} = 1;
    144144
    145145    push(@classDefinition, "class $className {");

  • trunk/WebCore/inspector/InspectorTimelineAgent.cpp

    r62549 r62656  
    6666        record->set("data", TimelineRecordFactory::createGCEventData(i->collectedBytes));
    6767        record->setNumber("endTime", i->endTime);
    68         addRecordToTimeline(record, GCEventTimelineRecordType);
     68        addRecordToTimeline(record.release(), GCEventTimelineRecordType);
    6969    }
    7070}
    … …  
    152152    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
    153153    record->set("data", TimelineRecordFactory::createTimerInstallData(timerId, timeout, singleShot));
    154     addRecordToTimeline(record, TimerInstallTimelineRecordType);
     154    addRecordToTimeline(record.release(), TimerInstallTimelineRecordType);
    155155}
    156156
    … …  
    160160    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
    161161    record->set("data", TimelineRecordFactory::createGenericTimerData(timerId));
    162     addRecordToTimeline(record, TimerRemoveTimelineRecordType);
     162    addRecordToTimeline(record.release(), TimerRemoveTimelineRecordType);
    163163}
    164164
    … …  
    209209    record->set("data", TimelineRecordFactory::createScheduleResourceRequestData(url));
    210210    record->setNumber("type", ScheduleResourceRequestTimelineRecordType);
    211     addRecordToTimeline(record, ScheduleResourceRequestTimelineRecordType);
     211    addRecordToTimeline(record.release(), ScheduleResourceRequestTimelineRecordType);
    212212}
    213213
    … …  
    219219    record->set("data", TimelineRecordFactory::createResourceSendRequestData(identifier, isMainResource, request));
    220220    record->setNumber("type", ResourceSendRequestTimelineRecordType);
    221     setHeapSizeStatistic(record);
    222     m_frontend->addRecordToTimeline(record);
     221    setHeapSizeStatistic(record.get());
     222    m_frontend->addRecordToTimeline(record.release());
    223223}
    224224
    … …  
    249249    record->set("data", TimelineRecordFactory::createResourceFinishData(identifier, didFail));
    250250    record->setNumber("type", ResourceFinishTimelineRecordType);
    251     setHeapSizeStatistic(record);
    252     m_frontend->addRecordToTimeline(record);
     251    setHeapSizeStatistic(record.get());
     252    m_frontend->addRecordToTimeline(record.release());
    253253}
    254254
    … …  
    258258    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
    259259    record->set("data", TimelineRecordFactory::createMarkTimelineData(message));
    260     addRecordToTimeline(record, MarkTimelineRecordType);
     260    addRecordToTimeline(record.release(), MarkTimelineRecordType);
    261261}
    262262
    … …  
    265265    pushGCEventRecords();
    266266    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
    267     addRecordToTimeline(record, MarkDOMContentEventType);
     267    addRecordToTimeline(record.release(), MarkDOMContentEventType);
    268268}
    269269
    … …  
    272272    pushGCEventRecords();
    273273    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
    274     addRecordToTimeline(record, MarkLoadEventType);
     274    addRecordToTimeline(record.release(), MarkLoadEventType);
    275275}
    276276
    … …  
    287287}
    288288
    289 void InspectorTimelineAgent::addRecordToTimeline(const RefPtr<InspectorObject>& record, TimelineRecordType type)
    290 {
     289void InspectorTimelineAgent::addRecordToTimeline(PassRefPtr<InspectorObject> prpRecord, TimelineRecordType type)
     290{
     291    RefPtr<InspectorObject> record(prpRecord);
    291292    record->setNumber("type", type);
    292     setHeapSizeStatistic(record);
     293    setHeapSizeStatistic(record.get());
    293294    if (m_recordStack.isEmpty())
    294         m_frontend->addRecordToTimeline(record);
     295        m_frontend->addRecordToTimeline(record.release());
    295296    else {
    296297        TimelineRecordEntry parent = m_recordStack.last();
    297         parent.children->push(record);
     298        parent.children->push(record.release());
    298299    }
    299300}
    300301
    301 void InspectorTimelineAgent::setHeapSizeStatistic(const RefPtr<InspectorObject>& record)
     302void InspectorTimelineAgent::setHeapSizeStatistic(InspectorObject* record)
    302303{
    303304    size_t usedHeapSize = 0;
    … …  
    324325}
    325326
    326 void InspectorTimelineAgent::pushCurrentRecord(const RefPtr<InspectorObject>& data, TimelineRecordType type)
    327 {
    328     pushGCEventRecords();
    329     RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
    330     m_recordStack.append(TimelineRecordEntry(record, data, InspectorArray::create(), type));
     327void InspectorTimelineAgent::pushCurrentRecord(PassRefPtr<InspectorObject> data, TimelineRecordType type)
     328{
     329    pushGCEventRecords();
     330    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS());
     331    m_recordStack.append(TimelineRecordEntry(record.release(), data, InspectorArray::create(), type));
    331332}
    332333} // namespace WebCore

  • trunk/WebCore/inspector/InspectorTimelineAgent.h

    r62549 r62656  
    134134private:
    135135    struct TimelineRecordEntry {
    136         TimelineRecordEntry(const RefPtr<InspectorObject>& record, const RefPtr<InspectorObject>& data, const RefPtr<InspectorArray>& children, TimelineRecordType type)
     136        TimelineRecordEntry(PassRefPtr<InspectorObject> record, PassRefPtr<InspectorObject> data, PassRefPtr<InspectorArray> children, TimelineRecordType type)
    137137            : record(record), data(data), children(children), type(type)
    138138        {
    … …  
    144144    };
    145145       
    146     void pushCurrentRecord(const RefPtr<InspectorObject>&, TimelineRecordType);
    147     void setHeapSizeStatistic(const RefPtr<InspectorObject>& record);
     146    void pushCurrentRecord(PassRefPtr<InspectorObject>, TimelineRecordType);
     147    void setHeapSizeStatistic(InspectorObject* record);
    148148       
    149149    void didCompleteCurrentRecord(TimelineRecordType);
    150150
    151     void addRecordToTimeline(const RefPtr<InspectorObject>&, TimelineRecordType);
     151    void addRecordToTimeline(PassRefPtr<InspectorObject>, TimelineRecordType);
    152152
    153153    void pushGCEventRecords();

  • trunk/WebCore/inspector/TimelineRecordFactory.cpp

    r62542 r62656  
    4545namespace WebCore {
    4646
    47 RefPtr<InspectorObject> TimelineRecordFactory::createGenericRecord(double startTime)
     47PassRefPtr<InspectorObject> TimelineRecordFactory::createGenericRecord(double startTime)
    4848{
    4949    RefPtr<InspectorObject> record = InspectorObject::create();
    … …  
    5353    if (ScriptCallStack::stackTrace(5, stackTrace))
    5454        record->set("stackTrace", stackTrace);
    55     return record;
     55    return record.release();
    5656}
    5757
    58 RefPtr<InspectorObject> TimelineRecordFactory::createGCEventData(const size_t usedHeapSizeDelta)
     58PassRefPtr<InspectorObject> TimelineRecordFactory::createGCEventData(const size_t usedHeapSizeDelta)
    5959{
    6060    RefPtr<InspectorObject> data = InspectorObject::create();
    6161    data->setNumber("usedHeapSizeDelta", usedHeapSizeDelta);
    62     return data;
     62    return data.release();
    6363}
    6464
    65 RefPtr<InspectorObject> TimelineRecordFactory::createFunctionCallData(const String& scriptName, int scriptLine)
     65PassRefPtr<InspectorObject> TimelineRecordFactory::createFunctionCallData(const String& scriptName, int scriptLine)
    6666{
    6767    RefPtr<InspectorObject> data = InspectorObject::create();
    6868    data->setString("scriptName", scriptName);
    6969    data->setNumber("scriptLine", scriptLine);
    70     return data;
     70    return data.release();
    7171}
    7272
    73 RefPtr<InspectorObject> TimelineRecordFactory::createEventDispatchData(const Event& event)
     73PassRefPtr<InspectorObject> TimelineRecordFactory::createEventDispatchData(const Event& event)
    7474{
    7575    RefPtr<InspectorObject> data = InspectorObject::create();
    7676    data->setString("type", event.type().string());
    77     return data;
     77    return data.release();
    7878}
    7979
    80 RefPtr<InspectorObject> TimelineRecordFactory::createGenericTimerData(int timerId)
     80PassRefPtr<InspectorObject> TimelineRecordFactory::createGenericTimerData(int timerId)
    8181{
    8282    RefPtr<InspectorObject> data = InspectorObject::create();
    8383    data->setNumber("timerId", timerId);
    84     return data;
     84    return data.release();
    8585}
    8686
    87 RefPtr<InspectorObject> TimelineRecordFactory::createTimerInstallData(int timerId, int timeout, bool singleShot)
     87PassRefPtr<InspectorObject> TimelineRecordFactory::createTimerInstallData(int timerId, int timeout, bool singleShot)
    8888{
    8989    RefPtr<InspectorObject> data = InspectorObject::create();
    … …  
    9191    data->setNumber("timeout", timeout);
    9292    data->setBool("singleShot", singleShot);
    93     return data;
     93    return data.release();
    9494}
    9595
    96 RefPtr<InspectorObject> TimelineRecordFactory::createXHRReadyStateChangeData(const String& url, int readyState)
     96PassRefPtr<InspectorObject> TimelineRecordFactory::createXHRReadyStateChangeData(const String& url, int readyState)
    9797{
    9898    RefPtr<InspectorObject> data = InspectorObject::create();
    9999    data->setString("url", url);
    100100    data->setNumber("readyState", readyState);
    101     return data;
     101    return data.release();
    102102}
    103103
    104 RefPtr<InspectorObject> TimelineRecordFactory::createXHRLoadData(const String& url)
     104PassRefPtr<InspectorObject> TimelineRecordFactory::createXHRLoadData(const String& url)
    105105{
    106106    RefPtr<InspectorObject> data = InspectorObject::create();
    107107    data->setString("url", url);
    108     return data;
     108    return data.release();
    109109}
    110110
    111 RefPtr<InspectorObject> TimelineRecordFactory::createEvaluateScriptData(const String& url, double lineNumber)
     111PassRefPtr<InspectorObject> TimelineRecordFactory::createEvaluateScriptData(const String& url, double lineNumber)
    112112{
    113113    RefPtr<InspectorObject> data = InspectorObject::create();
    114114    data->setString("url", url);
    115115    data->setNumber("lineNumber", lineNumber);
    116     return data;
     116    return data.release();
    117117}
    118118
    119 RefPtr<InspectorObject> TimelineRecordFactory::createMarkTimelineData(const String& message)
     119PassRefPtr<InspectorObject> TimelineRecordFactory::createMarkTimelineData(const String& message)
    120120{
    121121    RefPtr<InspectorObject> data = InspectorObject::create();
    122122    data->setString("message", message);
    123     return data;
     123    return data.release();
    124124}
    125125
    126 RefPtr<InspectorObject> TimelineRecordFactory::createScheduleResourceRequestData(const String& url)
     126PassRefPtr<InspectorObject> TimelineRecordFactory::createScheduleResourceRequestData(const String& url)
    127127{
    128128    RefPtr<InspectorObject> data = InspectorObject::create();
    129129    data->setString("url", url);
    130     return data;
     130    return data.release();
    131131}
    132132
    133 RefPtr<InspectorObject> TimelineRecordFactory::createResourceSendRequestData(unsigned long identifier, bool isMainResource, const ResourceRequest& request)
     133PassRefPtr<InspectorObject> TimelineRecordFactory::createResourceSendRequestData(unsigned long identifier, bool isMainResource, const ResourceRequest& request)
    134134{
    135135    RefPtr<InspectorObject> data = InspectorObject::create();
    … …  
    138138    data->setString("requestMethod", request.httpMethod());
    139139    data->setBool("isMainResource", isMainResource);
    140     return data;
     140    return data.release();
    141141}
    142142
    143 RefPtr<InspectorObject> TimelineRecordFactory::createResourceReceiveResponseData(unsigned long identifier, const ResourceResponse& response)
     143PassRefPtr<InspectorObject> TimelineRecordFactory::createResourceReceiveResponseData(unsigned long identifier, const ResourceResponse& response)
    144144{
    145145    RefPtr<InspectorObject> data = InspectorObject::create();
    … …  
    148148    data->setString("mimeType", response.mimeType());
    149149    data->setNumber("expectedContentLength", response.expectedContentLength());
    150     return data;
     150    return data.release();
    151151}
    152152
    153 RefPtr<InspectorObject> TimelineRecordFactory::createResourceFinishData(unsigned long identifier, bool didFail)
     153PassRefPtr<InspectorObject> TimelineRecordFactory::createResourceFinishData(unsigned long identifier, bool didFail)
    154154{
    155155    RefPtr<InspectorObject> data = InspectorObject::create();
    156156    data->setNumber("identifier", identifier);
    157157    data->setBool("didFail", didFail);
    158     return data;
     158    return data.release();
    159159}
    160160
    161 RefPtr<InspectorObject> TimelineRecordFactory::createReceiveResourceData(unsigned long identifier)
     161PassRefPtr<InspectorObject> TimelineRecordFactory::createReceiveResourceData(unsigned long identifier)
    162162{
    163163    RefPtr<InspectorObject> data = InspectorObject::create();
    164164    data->setNumber("identifier", identifier);
    165     return data;
     165    return data.release();
    166166}
    167167   
    168 RefPtr<InspectorObject> TimelineRecordFactory::createPaintData(const IntRect& rect)
     168PassRefPtr<InspectorObject> TimelineRecordFactory::createPaintData(const IntRect& rect)
    169169{
    170170    RefPtr<InspectorObject> data = InspectorObject::create();
    … …  
    173173    data->setNumber("width", rect.width());
    174174    data->setNumber("height", rect.height());
    175     return data;
     175    return data.release();
    176176}
    177177
    178 RefPtr<InspectorObject> TimelineRecordFactory::createParseHTMLData(unsigned int length, unsigned int startLine)
     178PassRefPtr<InspectorObject> TimelineRecordFactory::createParseHTMLData(unsigned int length, unsigned int startLine)
    179179{
    180180    RefPtr<InspectorObject> data = InspectorObject::create();
    181181    data->setNumber("length", length);
    182182    data->setNumber("startLine", startLine);
    183     return data;
     183    return data.release();
    184184}
    185185

  • trunk/WebCore/inspector/TimelineRecordFactory.h

    r62542 r62656  
    4545    class TimelineRecordFactory {
    4646    public:
    47         static RefPtr<InspectorObject> createGenericRecord(double startTime);
     47        static PassRefPtr<InspectorObject> createGenericRecord(double startTime);
    4848
    49         static RefPtr<InspectorObject> createGCEventData(const size_t usedHeapSizeDelta);
     49        static PassRefPtr<InspectorObject> createGCEventData(const size_t usedHeapSizeDelta);
    5050
    51         static RefPtr<InspectorObject> createFunctionCallData(const String& scriptName, int scriptLine);
     51        static PassRefPtr<InspectorObject> createFunctionCallData(const String& scriptName, int scriptLine);
    5252
    53         static RefPtr<InspectorObject> createEventDispatchData(const Event&);
     53        static PassRefPtr<InspectorObject> createEventDispatchData(const Event&);
    5454
    55         static RefPtr<InspectorObject> createGenericTimerData(int timerId);
     55        static PassRefPtr<InspectorObject> createGenericTimerData(int timerId);
    5656
    57         static RefPtr<InspectorObject> createTimerInstallData(int timerId, int timeout, bool singleShot);
     57        static PassRefPtr<InspectorObject> createTimerInstallData(int timerId, int timeout, bool singleShot);
    5858
    59         static RefPtr<InspectorObject> createXHRReadyStateChangeData(const String& url, int readyState);
     59        static PassRefPtr<InspectorObject> createXHRReadyStateChangeData(const String& url, int readyState);
    6060
    61         static RefPtr<InspectorObject> createXHRLoadData(const String& url);
     61        static PassRefPtr<InspectorObject> createXHRLoadData(const String& url);
    6262
    63         static RefPtr<InspectorObject> createEvaluateScriptData(const String&, double lineNumber);
     63        static PassRefPtr<InspectorObject> createEvaluateScriptData(const String&, double lineNumber);
    6464
    65         static RefPtr<InspectorObject> createMarkTimelineData(const String&);
     65        static PassRefPtr<InspectorObject> createMarkTimelineData(const String&);
    6666
    67         static RefPtr<InspectorObject> createResourceSendRequestData(unsigned long identifier,
     67        static PassRefPtr<InspectorObject> createResourceSendRequestData(unsigned long identifier,
    6868            bool isMainResource, const ResourceRequest&);
    6969
    70         static RefPtr<InspectorObject> createScheduleResourceRequestData(const String&);
     70        static PassRefPtr<InspectorObject> createScheduleResourceRequestData(const String&);
    7171
    72         static RefPtr<InspectorObject> createResourceReceiveResponseData(unsigned long identifier, const ResourceResponse&);
     72        static PassRefPtr<InspectorObject> createResourceReceiveResponseData(unsigned long identifier, const ResourceResponse&);
    7373
    74         static RefPtr<InspectorObject> createReceiveResourceData(unsigned long identifier);
     74        static PassRefPtr<InspectorObject> createReceiveResourceData(unsigned long identifier);
    7575
    76         static RefPtr<InspectorObject> createResourceFinishData(unsigned long identifier, bool didFail);
     76        static PassRefPtr<InspectorObject> createResourceFinishData(unsigned long identifier, bool didFail);
    7777
    78         static RefPtr<InspectorObject> createPaintData(const IntRect&);
     78        static PassRefPtr<InspectorObject> createPaintData(const IntRect&);
    7979
    80         static RefPtr<InspectorObject> createParseHTMLData(unsigned int length, unsigned int startLine);
     80        static PassRefPtr<InspectorObject> createParseHTMLData(unsigned int length, unsigned int startLine);
    8181
    8282    private:
Note: See TracChangeset for help on using the changeset viewer.