Changeset 62798 in webkit

Timestamp:

Jul 8, 2010 10:26:22 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62778.
​http://trac.webkit.org/changeset/62778
​https://bugs.webkit.org/show_bug.cgi?id=41866

Broke svg/W3C-SVG-1.1/text-intro-05-t.svg in debug (Requested
by pfeldman on #webkit).

• fast/text/international/bidi-mirror-he-ar.html: Removed.
• platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed.
• platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png: Removed.
• platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.

2010-07-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62778.
​http://trac.webkit.org/changeset/62778
​https://bugs.webkit.org/show_bug.cgi?id=41866

Broke svg/W3C-SVG-1.1/text-intro-05-t.svg in debug (Requested
by pfeldman on #webkit).

• platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/international/bidi-mirror-he-ar.html (deleted)
• LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum (deleted)
• LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png (deleted)
• LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt (deleted)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/chromium/FontLinux.cpp (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-08  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r62778.
+        http://trac.webkit.org/changeset/62778
+        https://bugs.webkit.org/show_bug.cgi?id=41866
+
+        Broke svg/W3C-SVG-1.1/text-intro-05-t.svg in debug (Requested
+        by pfeldman on #webkit).
+
+        * fast/text/international/bidi-mirror-he-ar.html: Removed.
+        * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed.
+        * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png: Removed.
+        * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
+
 2010-07-08  Andreas Kling  <andreas.kling@nokia.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-08  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r62778.
+        http://trac.webkit.org/changeset/62778
+        https://bugs.webkit.org/show_bug.cgi?id=41866
+
+        Broke svg/W3C-SVG-1.1/text-intro-05-t.svg in debug (Requested
+        by pfeldman on #webkit).
+
+        * platform/graphics/chromium/FontLinux.cpp:
+        (WebCore::TextRunWalker::TextRunWalker):
+        (WebCore::TextRunWalker::~TextRunWalker):
+
 2010-07-08  Vitaly Repeshko  <vitalyr@chromium.org>
 

trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

@@ -50 +50 @@
 #include <wtf/OwnArrayPtr.h>
 #include <wtf/OwnPtr.h>
-#include <wtf/unicode/Unicode.h>
 
 namespace WebCore {
@@ -182 +181 @@
         m_item.font = allocHarfbuzzFont();
 
+        m_item.string = m_run.characters();
+        m_item.stringLength = m_run.length();
         m_item.item.bidiLevel = m_run.rtl();
-
-        int length = m_run.length();
-        m_item.stringLength = length;
-
-        if (!m_item.item.bidiLevel)
-            m_item.string = m_run.characters();
-        else {
-            // Assume mirrored character is in the same multilingual plane as the original one.
-            UChar* string = new UChar[length];
-            mirrorCharacters(string, m_run.characters(), length);
-            m_item.string = string;
-        }
 
         reset();
@@ -204 +193 @@
         deleteGlyphArrays();
         delete[] m_item.log_clusters;
-        if (m_item.item.bidiLevel)
-            delete[] m_item.string;
     }
 
@@ -469 +456 @@
     }
 
-    void mirrorCharacters(UChar* destination, const UChar* source, int length) const
-    {
-        int position = 0;
-        bool error;
-        // Iterate characters in source and mirror character if needed.
-        while (position < length) {
-            UChar32 character;
-            int nextPosition = position;
-            U16_NEXT(source, nextPosition, length, character);
-            character = u_charMirror(character);
-            U16_APPEND(destination, position, length, character, error);
-            ASSERT(!error);
-            position = nextPosition;
-        }
-    }
-
     const Font* const m_font;
     HB_ShaperItem m_item;