Changeset 62880 in webkit


Ignore:
Timestamp:
Jul 8, 2010 7:20:24 PM (14 years ago)
Author:
weinig@apple.com
Message:

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=41923
TimeRanges should expose a JS constructor

Reviewed by Oliver Hunt.

WebCore:

  • html/TimeRanges.idl: Remove [OmitConstructor].
  • page/DOMWindow.idl: Add constructor.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62877 r62880  
     12010-07-08  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        Fix for https://bugs.webkit.org/show_bug.cgi?id=41923
     6        TimeRanges should expose a JS constructor
     7
     8        * fast/dom/Window/window-properties-expected.txt:
     9        * fast/dom/Window/window-property-descriptors-expected.txt:
     10        * fast/dom/prototype-inheritance-2-expected.txt:
     11        * fast/dom/prototype-inheritance-expected.txt:
     12        * fast/js/global-constructors-expected.txt:
     13        * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
     14        * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
     15        * platform/win/fast/dom/prototype-inheritance-expected.txt:
     16        * platform/win/fast/js/global-constructors-expected.txt:
     17
    1182010-07-08  Erik Arvidsson  <arv@chromium.org>
    219

  • trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

    r62834 r62880  
    18951895window.TextMetrics [object TextMetricsConstructor]
    18961896window.TextMetrics.prototype [object TextMetricsPrototype]
     1897window.TimeRanges [object TimeRangesConstructor]
     1898window.TimeRanges.prototype [object TimeRangesPrototype]
     1899window.TimeRanges.prototype.end [function]
     1900window.TimeRanges.prototype.start [function]
    18971901window.TypeError [function]
    18981902window.UIEvent [object UIEventConstructor]

  • trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt

    r62215 r62880  
    304304PASS typeof Object.getOwnPropertyDescriptor(window, 'TextEvent') is 'object'
    305305PASS typeof Object.getOwnPropertyDescriptor(window, 'TextMetrics') is 'object'
     306PASS typeof Object.getOwnPropertyDescriptor(window, 'TimeRanges') is 'object'
    306307PASS typeof Object.getOwnPropertyDescriptor(window, 'TypeError') is 'object'
    307308PASS typeof Object.getOwnPropertyDescriptor(window, 'UIEvent') is 'object'

  • trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt

    r62215 r62880  
    202202PASS TextPrototype from inner.document.forms.testForm.0.attributes.0.lastChild.__proto__
    203203PASS TimeRanges from inner.document.forms.testForm.0.previousElementSibling.played
     204PASS TimeRangesConstructor from inner.document.forms.testForm.0.previousElementSibling.played.constructor
    204205PASS TimeRangesPrototype from inner.document.forms.testForm.0.previousElementSibling.played.__proto__
    205206PASS ValidityState from inner.document.forms.testForm.0.0.validity

  • trunk/LayoutTests/fast/dom/prototype-inheritance-expected.txt

    r62215 r62880  
    578578PASS inner.TextMetrics.isInner is true
    579579PASS inner.TextMetrics.constructor.isInner is true
     580PASS inner.TimeRanges.isInner is true
     581PASS inner.TimeRanges.constructor.isInner is true
    580582PASS inner.TypeError.isInner is true
    581583PASS inner.TypeError.constructor.isInner is true

  • trunk/LayoutTests/fast/js/global-constructors-expected.txt

    r62215 r62880  
    287287PASS TextEvent.toString() is '[object TextEventConstructor]'
    288288PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
     289PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
    289290PASS UIEvent.toString() is '[object UIEventConstructor]'
    290291PASS WebKitAnimationEvent.toString() is '[object WebKitAnimationEventConstructor]'

  • trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt

    r62402 r62880  
    302302PASS typeof Object.getOwnPropertyDescriptor(window, 'TextEvent') is 'object'
    303303PASS typeof Object.getOwnPropertyDescriptor(window, 'TextMetrics') is 'object'
     304PASS typeof Object.getOwnPropertyDescriptor(window, 'TimeRanges') is 'object'
    304305PASS typeof Object.getOwnPropertyDescriptor(window, 'TypeError') is 'object'
    305306PASS typeof Object.getOwnPropertyDescriptor(window, 'UIEvent') is 'object'

  • trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt

    r62402 r62880  
    202202PASS TextPrototype from inner.document.forms.testForm.0.attributes.0.lastChild.__proto__
    203203PASS TimeRanges from inner.document.forms.testForm.0.previousElementSibling.played
     204PASS TimeRangesConstructor from inner.document.forms.testForm.0.previousElementSibling.played.constructor
    204205PASS TimeRangesPrototype from inner.document.forms.testForm.0.previousElementSibling.played.__proto__
    205206PASS ValidityState from inner.document.forms.testForm.0.0.validity

  • trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-expected.txt

    r62402 r62880  
    574574PASS inner.TextMetrics.isInner is true
    575575PASS inner.TextMetrics.constructor.isInner is true
     576PASS inner.TimeRanges.isInner is true
     577PASS inner.TimeRanges.constructor.isInner is true
    576578PASS inner.TypeError.isInner is true
    577579PASS inner.TypeError.constructor.isInner is true

  • trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt

    r62402 r62880  
    285285PASS TextEvent.toString() is '[object TextEventConstructor]'
    286286PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
     287PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
    287288PASS UIEvent.toString() is '[object UIEventConstructor]'
    288289PASS WebKitAnimationEvent.toString() is '[object WebKitAnimationEventConstructor]'

  • trunk/WebCore/ChangeLog

    r62877 r62880  
     12010-07-08  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        Fix for https://bugs.webkit.org/show_bug.cgi?id=41923
     6        TimeRanges should expose a JS constructor
     7
     8        * html/TimeRanges.idl: Remove [OmitConstructor].
     9        * page/DOMWindow.idl: Add constructor.
     10
    1112010-07-08  Erik Arvidsson  <arv@chromium.org>
    212

  • trunk/WebCore/html/TimeRanges.idl

    r52534 r62880  
    11/*
    2  * Copyright (C) 2007 Apple Inc.  All rights reserved.
     2 * Copyright (C) 2007, 2010 Apple Inc.  All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2626module html {
    2727
    28 interface [Conditional=VIDEO, OmitConstructor] TimeRanges {
    29     readonly attribute unsigned long length;
    30     float start(in unsigned long index)
    31         raises (DOMException);
    32     float end(in unsigned long index)
    33         raises (DOMException);
    34 };
     28    interface [
     29        Conditional=VIDEO
     30    ] TimeRanges {
     31        readonly attribute unsigned long length;
     32        float start(in unsigned long index)
     33            raises (DOMException);
     34        float end(in unsigned long index)
     35            raises (DOMException);
     36    };
    3537
    3638}

  • trunk/WebCore/page/DOMWindow.idl

    r62653 r62880  
    572572        attribute [Conditional=VIDEO, EnabledAtRuntime] HTMLVideoElementConstructor HTMLVideoElement;
    573573        attribute [Conditional=VIDEO, EnabledAtRuntime] MediaErrorConstructor MediaError;
     574        attribute [Conditional=VIDEO, EnabledAtRuntime] TimeRangesConstructor TimeRanges;
    574575
    575576#if defined(ENABLE_XPATH) && ENABLE_XPATH
Note: See TracChangeset for help on using the changeset viewer.