Changeset 63204 in webkit

Timestamp:

Jul 13, 2010 7:33:30 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-07-13 Leon Clarke <​leonclarke@google.com>

Reviewed by Pavel Feldman.

Don't access objects after deleting them, following
the addition of link prefetching. Also remove a forward declaration
of the now-nonexistent CachedLinkPrefetch class.
​https://bugs.webkit.org/show_bug.cgi?id=3652

No new tests. Correcting aspects of the prefetch change that shouldn't
have affected functionality.

• html/HTMLLinkElement.h:
• loader/loader.cpp: (WebCore::Loader::Host::cancelPendingRequests):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLLinkElement.h (modified) (1 diff)
• loader/loader.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-13  Leon Clarke  <leonclarke@google.com>
+
+        Reviewed by Pavel Feldman.
+
+        Don't access objects after deleting them, following
+        the addition of link prefetching. Also remove a forward declaration
+        of the now-nonexistent CachedLinkPrefetch class.
+        https://bugs.webkit.org/show_bug.cgi?id=3652
+
+        No new tests. Correcting aspects of the prefetch change that shouldn't
+        have affected functionality.
+
+        * html/HTMLLinkElement.h:
+        * loader/loader.cpp:
+        (WebCore::Loader::Host::cancelPendingRequests):
+
 2010-07-13  Andras Becsi  <abecsi@webkit.org>
 

trunk/WebCore/html/HTMLLinkElement.h

@@ -32 +32 @@
 
 class CachedCSSStyleSheet;
-class CachedLinkPrefetch;
 class KURL;
 

trunk/WebCore/loader/loader.cpp

@@ -591 +591 @@
         if (request->docLoader() == docLoader) {
             cache()->remove(request->cachedResource());
+            docLoader->decrementRequestCount(request->cachedResource());
             delete request;
-            docLoader->decrementRequestCount(request->cachedResource());
         } else
             remaining.append(request);