Changeset 63317 in webkit


Ignore:
Timestamp:
Jul 14, 2010 7:22:49 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-14 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Rename DeviceOrientationController::onOrientationChange to didChangeDeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=42257

According to convention, we should avoid "on" in favor of "did" in function names.

  • dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
  • dom/DeviceOrientationController.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r63316 r63317  
     12010-07-14  Hans Wennborg  <hans@chromium.org>
     2
     3        Reviewed by Steve Block.
     4
     5        Rename DeviceOrientationController::onOrientationChange to didChangeDeviceOrientation
     6        https://bugs.webkit.org/show_bug.cgi?id=42257
     7
     8        According to convention, we should avoid "on" in favor of "did" in function names.
     9
     10        * dom/DeviceOrientationController.cpp:
     11        (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
     12        * dom/DeviceOrientationController.h:
     13
    1142010-07-14  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
    215
  • trunk/WebCore/dom/DeviceOrientationController.cpp

    r63312 r63317  
    7777}
    7878
    79 void DeviceOrientationController::onDeviceOrientationChange(DeviceOrientation* orientation)
     79void DeviceOrientationController::didChangeDeviceOrientation(DeviceOrientation* orientation)
    8080{
    8181    RefPtr<DeviceOrientationEvent> event = DeviceOrientationEvent::create(eventNames().deviceorientationEvent, orientation);
  • trunk/WebCore/dom/DeviceOrientationController.h

    r63312 r63317  
    4444    void removeAllListeners(DOMWindow*);
    4545
    46     void onDeviceOrientationChange(DeviceOrientation*);
     46    void didChangeDeviceOrientation(DeviceOrientation*);
    4747
    4848private:
Note: See TracChangeset for help on using the changeset viewer.