Changeset 63409 in webkit


Ignore:
Timestamp:
Jul 14, 2010 11:49:28 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63352.
​http://trac.webkit.org/changeset/63352
​https://bugs.webkit.org/show_bug.cgi?id=42341

Broke plugin-initiate-popup-window.html and plugin-javascript-
access.html on snow leopard (Requested by abarth on #webkit).

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/plugin-initiate-popup-window-expected.txt: Removed.
  • plugins/plugin-initiate-popup-window.html: Removed.

2010-07-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63352.
​http://trac.webkit.org/changeset/63352
​https://bugs.webkit.org/show_bug.cgi?id=42341

Broke plugin-initiate-popup-window.html and plugin-javascript-
access.html on snow leopard (Requested by abarth on #webkit).

  • bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):

2010-07-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63352.
​http://trac.webkit.org/changeset/63352
​https://bugs.webkit.org/show_bug.cgi?id=42341

Broke plugin-initiate-popup-window.html and plugin-javascript-
access.html on snow leopard (Requested by abarth on #webkit).

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa):
Location:
trunk
Files:
2 deleted
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r63408 r63409  
     12010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r63352.
     4        http://trac.webkit.org/changeset/63352
     5        https://bugs.webkit.org/show_bug.cgi?id=42341
     6
     7        Broke plugin-initiate-popup-window.html and plugin-javascript-
     8        access.html on snow leopard (Requested by abarth on #webkit).
     9
     10        * platform/chromium/test_expectations.txt:
     11        * platform/gtk/Skipped:
     12        * platform/qt/Skipped:
     13        * platform/win/Skipped:
     14        * plugins/plugin-initiate-popup-window-expected.txt: Removed.
     15        * plugins/plugin-initiate-popup-window.html: Removed.
     16
    1172010-07-14  Martin Robinson  <mrobinson@igalia.com>
    218

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r63352 r63409  
    30033003BUG48737 WIN LINUX MAC SKIP : ietestcenter/Javascript/15.4.4.15-3-8.html = TIMEOUT
    30043004
    3005 // Implement new test logic in Chromium's TestNetscape Plugin to pass the plugins/plugin-initiate-popup-window.html
    3006 BUG48033 SKIP : plugins/plugin-initiate-popup-window.html = TIMEOUT
    3007 
    30083005// Broken prior to r62921.
    30093006BUG48696 WIN LINUX : fast/forms/focus2.html = CRASH

  • trunk/LayoutTests/platform/gtk/Skipped

    r63352 r63409  
    33423342#   These test require Qt Widgets
    33433343plugins/qt-qwidget-plugin.html
    3344 #   Tests failing, need to implement NPP_HandleEvent() in TestNetscapePlugin
     3344#   Tests failing
    33453345plugins/embed-attributes-setting.html
    33463346plugins/get-url-with-blank-target.html
    … …  
    33493349plugins/keyboard-events.html
    33503350plugins/geturlnotify-during-document-teardown.html
    3351 plugins/plugin-initiate-popup-window.html
    33523351
    33533352# This test is for clients that choose to make the missing plugin indicator a button

  • trunk/LayoutTests/platform/qt/Skipped

    r63352 r63409  
    458458plugins/keyboard-events.html
    459459plugins/mouse-events-fixedpos.html
    460 plugins/plugin-initiate-popup-window.html
    461460# ---- to be reviewed
    462461http/tests/plugins/plugin-document-has-focus.html

  • trunk/LayoutTests/platform/win/Skipped

    r63352 r63409  
    805805plugins/keyboard-events.html
    806806http/tests/plugins/plugin-document-has-focus.html
    807 plugins/plugin-initiate-popup-window.html
    808807
    809808# DumpRenderTree code to enable Java is currently a no-op. Windows doesn't come with Java by default.

  • trunk/WebCore/ChangeLog

    r63403 r63409  
     12010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r63352.
     4        http://trac.webkit.org/changeset/63352
     5        https://bugs.webkit.org/show_bug.cgi?id=42341
     6
     7        Broke plugin-initiate-popup-window.html and plugin-javascript-
     8        access.html on snow leopard (Requested by abarth on #webkit).
     9
     10        * bindings/v8/NPV8Object.cpp:
     11        (_NPN_EvaluateHelper):
     12
    1132010-07-14  Eric Seidel  <eric@webkit.org>
    214

  • trunk/WebCore/bindings/v8/NPV8Object.cpp

    r63352 r63409  
    3535#include "PlatformString.h"
    3636#include "ScriptController.h"
    37 #include "UserGestureIndicator.h"
    3837#include "V8GCController.h"
    3938#include "V8Helpers.h"
    … …  
    279278    if (!popupsAllowed)
    280279        filename = "npscript";
    281 
    282     UserGestureIndicator gestureIndicator(popupsAllowed ? DefinitelyProcessingUserGesture : DefinitelyNotProcessingUserGesture);
    283280
    284281    String script = String::fromUTF8(npScript->UTF8Characters, npScript->UTF8Length);

  • trunk/WebKitTools/ChangeLog

    r63399 r63409  
     12010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r63352.
     4        http://trac.webkit.org/changeset/63352
     5        https://bugs.webkit.org/show_bug.cgi?id=42341
     6
     7        Broke plugin-initiate-popup-window.html and plugin-javascript-
     8        access.html on snow leopard (Requested by abarth on #webkit).
     9
     10        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
     11        (pluginAllocate):
     12        * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
     13        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
     14        (NPP_New):
     15        (handleEventCarbon):
     16        (handleEventCocoa):
     17
    1182010-07-14  Maciej Stachowiak  <mjs@apple.com>
    219

  • trunk/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp

    r63352 r63409  
    979979    newInstance->stream = 0;
    980980
    981     newInstance->firstUrl = 0;
    982     newInstance->firstHeaders = 0;
    983     newInstance->lastUrl = 0;
    984     newInstance->lastHeaders = 0;
     981    newInstance->firstUrl = NULL;
     982    newInstance->firstHeaders = NULL;
     983    newInstance->lastUrl = NULL;
     984    newInstance->lastHeaders = NULL;
    985985
    986986    newInstance->testGetURLOnDestroy = FALSE;
    … …  
    988988    newInstance->testWindowOpen = FALSE;
    989989    newInstance->testKeyboardFocusForPlugins = FALSE;
    990 
    991     newInstance->mouseDownForEvaluateScript = FALSE;
    992     newInstance->evaluateScriptOnMouseDownOrKeyDown = 0;
    993990
    994991    return (NPObject*)newInstance;

  • trunk/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h

    r63352 r63409  
    5555    NPBool testWindowOpen;
    5656    NPBool testKeyboardFocusForPlugins;
    57     NPBool mouseDownForEvaluateScript;
    5857    char* onStreamLoad;
    5958    char* onStreamDestroy;
    … …  
    6564    char* lastUrl;
    6665    char* lastHeaders;
    67     char* evaluateScriptOnMouseDownOrKeyDown;
    6866#ifdef XP_MACOSX
    6967    NPEventModel eventModel;

  • trunk/WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp

    r63352 r63409  
    184184            obj->testGetURLOnDestroy = TRUE;
    185185#endif
    186         } else if (!strcasecmp(argn[i], "src") && strstr(argv[i], "plugin-document-has-focus.pl"))
     186        } else if (strcasecmp(argn[i], "src") == 0 && strstr(argv[i], "plugin-document-has-focus.pl"))
    187187            obj->testKeyboardFocusForPlugins = TRUE;
    188         else if (!strcasecmp(argn[i], "evaluatescript")) {
    189             char* script = argv[i];
    190             if (script == strstr(script, "mouse::")) {
    191                 obj->mouseDownForEvaluateScript = true;
    192                 obj->evaluateScriptOnMouseDownOrKeyDown = strdup(script + sizeof("mouse::") - 1);
    193             } else if (script == strstr(script, "key::")) {
    194                 obj->evaluateScriptOnMouseDownOrKeyDown = strdup(script + sizeof("key::") - 1);
    195             }
    196             // When testing evaluate script on mouse-down or key-down, allow event logging to handle events.
    197             if (obj->evaluateScriptOnMouseDownOrKeyDown)
    198                 obj->eventLogging = true;
    199         }
    200188    }
    201189
    … …  
    382370            GlobalToLocal(&pt);
    383371            pluginLog(instance, "mouseDown at (%d, %d)", pt.h, pt.v);
    384             if (obj->evaluateScriptOnMouseDownOrKeyDown && obj->mouseDownForEvaluateScript)
    385                 executeScript(obj, obj->evaluateScriptOnMouseDownOrKeyDown);
    386372            break;
    387373        case mouseUp:
    … …  
    391377        case keyDown:
    392378            pluginLog(instance, "keyDown '%c'", (char)(event->message & 0xFF));
    393             if (obj->evaluateScriptOnMouseDownOrKeyDown && !obj->mouseDownForEvaluateScript)
    394                 executeScript(obj, obj->evaluateScriptOnMouseDownOrKeyDown);
    395379            break;
    396380        case keyUp:
    … …  
    466450            if (event->data.key.characters)
    467451                pluginLog(instance, "keyDown '%c'", CFStringGetCharacterAtIndex(reinterpret_cast<CFStringRef>(event->data.key.characters), 0));
    468             if (obj->evaluateScriptOnMouseDownOrKeyDown && !obj->mouseDownForEvaluateScript)
    469                 executeScript(obj, obj->evaluateScriptOnMouseDownOrKeyDown);
    470452            return 1;
    471453
    … …  
    488470                   (int)event->data.mouse.pluginX,
    489471                   (int)event->data.mouse.pluginY);
    490             if (obj->evaluateScriptOnMouseDownOrKeyDown && obj->mouseDownForEvaluateScript)
    491                 executeScript(obj, obj->evaluateScriptOnMouseDownOrKeyDown);
    492472            return 1;
    493473        case NPCocoaEventMouseUp:
Note: See TracChangeset for help on using the changeset viewer.