Changeset 63413 in webkit

Timestamp:

Jul 15, 2010 12:34:13 AM (14 years ago)

Author:

Nikolas Zimmermann

Message:

2010-07-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Adam Barth.

Pixel test failure in moving-shadow-on-path.html and moving-shadow-on-container.html
​https://bugs.webkit.org/show_bug.cgi?id=42249

Partly revert <​http://trac.webkit.org/changeset/63307>. The RenderSVGRoot change caused a pixel test regression in two fast/repaint tests.

• rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Include selfNeedsLayout() check in LayoutStateRepainter argument.

2010-07-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Adam Barth.

Pixel test failure in moving-shadow-on-path.html and moving-shadow-on-container.html
​https://bugs.webkit.org/show_bug.cgi?id=42249

Update fast/repaint/moving-shadow-on-path.html result, which shows a slightly smaller repaint rect.

• platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
• platform/mac/fast/repaint/moving-shadow-on-path-expected.png:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/repaint/moving-shadow-on-path-expected.png (modified) (previous)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderSVGRoot.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-15  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Adam Barth.
+
+        Pixel test failure in moving-shadow-on-path.html and moving-shadow-on-container.html
+        https://bugs.webkit.org/show_bug.cgi?id=42249
+
+        Update fast/repaint/moving-shadow-on-path.html result, which shows a slightly smaller repaint rect.
+
+        * platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
+        * platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
+
 2010-07-15  Maciej Stachowiak  <mjs@apple.com>
 

trunk/LayoutTests/platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum

@@ -1 @@
-c1d3ba33405df28796a36d5b1b225097
+3d148ca8ecc0067a2307da77ac8bf690

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-15  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Adam Barth.
+
+        Pixel test failure in moving-shadow-on-path.html and moving-shadow-on-container.html
+        https://bugs.webkit.org/show_bug.cgi?id=42249
+
+        Partly revert <http://trac.webkit.org/changeset/63307>. The RenderSVGRoot change caused a pixel test regression in two fast/repaint tests.
+
+        * rendering/RenderSVGRoot.cpp:
+        (WebCore::RenderSVGRoot::layout): Include selfNeedsLayout() check in LayoutStateRepainter argument.
+
 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/rendering/RenderSVGRoot.cpp

@@ -109 +109 @@
     view()->disableLayoutState();
 
-    LayoutRepainter repainter(*this, m_everHadLayout && checkForRepaintDuringLayout());
+    bool needsLayout = selfNeedsLayout();
+    LayoutRepainter repainter(*this, needsLayout && m_everHadLayout && checkForRepaintDuringLayout());
 
     IntSize oldSize(width(), height());
@@ -119 +120 @@
     m_isLayoutSizeChanged = svg->hasRelativeLengths() && oldSize != size();
 
-    SVGRenderSupport::layoutChildren(this, selfNeedsLayout());
+    SVGRenderSupport::layoutChildren(this, needsLayout);
     m_isLayoutSizeChanged = false;