Changeset 63450 in webkit


Ignore:
Timestamp:
Jul 15, 2010 1:02:04 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-15 Alex Nicolaou <anicolao@chromium.org>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=42228

SVG Masks were in the wrong colour space for non-CG graphics layers,
because for those cases ImageBuffer needs to be explicitly told to
convert the pixels. This change adds a test that demonstrates the
problem and the conversion call to make the mask LinearRGB.

  • platform/mac/svg/custom/mask-colorspace-expected.checksum: Added.
  • platform/mac/svg/custom/mask-colorspace-expected.png: Added.
  • platform/mac/svg/custom/mask-colorspace-expected.txt: Added.
  • svg/custom/mask-colorspace.svg: Added.

2010-07-15 Alex Nicolaou <anicolao@chromium.org>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=42228

SVG Masks were in the wrong colour space for non-CG graphics layers,
because for those cases ImageBuffer needs to be explicitly told to
convert the pixels. This change adds a test that demonstrates the
problem and the conversion call to make the mask LinearRGB.

Test: svg/custom/mask-colorspace.svg

  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::createMaskImage):
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r63448 r63450  
     12010-07-15  Alex Nicolaou  <anicolao@chromium.org>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=42228
     6       
     7        SVG Masks were in the wrong colour space for non-CG graphics layers,
     8        because for those cases ImageBuffer needs to be explicitly told to
     9        convert the pixels. This change adds a test that demonstrates the
     10        problem and the conversion call to make the mask LinearRGB.
     11
     12        * platform/mac/svg/custom/mask-colorspace-expected.checksum: Added.
     13        * platform/mac/svg/custom/mask-colorspace-expected.png: Added.
     14        * platform/mac/svg/custom/mask-colorspace-expected.txt: Added.
     15        * svg/custom/mask-colorspace.svg: Added.
     16
    1172010-07-15  Ojan Vafai  <ojan@chromium.org>
    218
  • trunk/WebCore/ChangeLog

    r63445 r63450  
     12010-07-15  Alex Nicolaou  <anicolao@chromium.org>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=42228
     6       
     7        SVG Masks were in the wrong colour space for non-CG graphics layers,
     8        because for those cases ImageBuffer needs to be explicitly told to
     9        convert the pixels. This change adds a test that demonstrates the
     10        problem and the conversion call to make the mask LinearRGB.
     11
     12        Test: svg/custom/mask-colorspace.svg
     13
     14        * rendering/RenderSVGResourceMasker.cpp:
     15        (WebCore::RenderSVGResourceMasker::createMaskImage):
     16
    1172010-07-15  Daniel Bates  <dbates@rim.com>
    218
  • trunk/WebCore/rendering/RenderSVGResourceMasker.cpp

    r63300 r63450  
    191191    maskImageContext->restore();
    192192
     193#if !PLATFORM(CG)
     194    maskerData->maskImage->transformColorSpace(DeviceRGB, LinearRGB);
     195#endif
     196
    193197    // create the luminance mask
    194198    RefPtr<ImageData> imageData(maskerData->maskImage->getUnmultipliedImageData(maskImageRect));
Note: See TracChangeset for help on using the changeset viewer.