Changeset 63549 in webkit

Timestamp:

Jul 16, 2010 8:33:30 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-07-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable AppCache in chromium.

​https://bugs.webkit.org/show_bug.cgi?id=41858

• inspector/front-end/Settings.js:
• inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache):2010-07-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable AppCache in chromium.

​https://bugs.webkit.org/show_bug.cgi?id=41858

• src/js/DevTools.js: (WebInspector.loaded):

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/front-end/Settings.js (modified) (1 diff)
• WebCore/inspector/front-end/StoragePanel.js (modified) (3 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/js/DevTools.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-16  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: disable AppCache in chromium.
+
+        https://bugs.webkit.org/show_bug.cgi?id=41858
+
+        * inspector/front-end/Settings.js:
+        * inspector/front-end/StoragePanel.js:
+        (WebInspector.StoragePanel):
+        (WebInspector.StoragePanel.prototype.reset):
+        (WebInspector.StoragePanel.prototype.addApplicationCache):
+
 2010-07-16  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebCore/inspector/front-end/Settings.js

@@ -43 +43 @@
     debuggerAlwaysEnabled: false,
     profilerAlwaysEnabled: false,
-    auditsPanelEnabled: true
+    auditsPanelEnabled: true,
+    appCacheEnabled: true
 }
 

trunk/WebCore/inspector/front-end/StoragePanel.js

@@ -50 +50 @@
     this.cookieListTreeElement.expand();
 
-    this.applicationCacheListTreeElement = new WebInspector.SidebarSectionTreeElement(WebInspector.UIString("APPLICATION CACHE"), {}, true);
-    this.sidebarTree.appendChild(this.applicationCacheListTreeElement);
-    this.applicationCacheListTreeElement.expand();
+    if (Preferences.appCacheEnabled) {
+        this.applicationCacheListTreeElement = new WebInspector.SidebarSectionTreeElement(WebInspector.UIString("APPLICATION CACHE"), {}, true);
+        this.sidebarTree.appendChild(this.applicationCacheListTreeElement);
+        this.applicationCacheListTreeElement.expand();
+    }
 
     this.storageViews = document.createElement("div");
@@ -109 +111 @@
         this.sessionStorageListTreeElement.removeChildren();
         this.cookieListTreeElement.removeChildren();
-        this.applicationCacheListTreeElement.removeChildren();
+
+        if (Preferences.appCacheEnabled)
+            this.applicationCacheListTreeElement.removeChildren();
 
         this.storageViews.removeChildren();
@@ -147 +151 @@
     addApplicationCache: function(domain)
     {
+        if (!Preferences.appCacheEnabled)
+            return;
         var applicationCacheTreeElement = new WebInspector.ApplicationCacheSidebarTreeElement(domain);
         this.applicationCacheListTreeElement.appendChild(applicationCacheTreeElement);

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-16  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: disable AppCache in chromium.
+
+        https://bugs.webkit.org/show_bug.cgi?id=41858
+
+        * src/js/DevTools.js:
+        (WebInspector.loaded):
+
 2010-07-16  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/WebKit/chromium/src/js/DevTools.js

@@ -144 +144 @@
     Preferences.profilerAlwaysEnabled = true;
     Preferences.canEditScriptSource = true;
+    Preferences.appCacheEnabled = false;
 
     oldLoaded.call(this);