Changeset 63560 in webkit

Timestamp:

Jul 16, 2010 9:50:51 AM (14 years ago)

Author:

rwlbuis@webkit.org

Message:

2010-07-15 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Darin Adler.

An empty value for xml:lang isn't considered
​https://bugs.webkit.org/show_bug.cgi?id=42042

Allow :lang selector to match empty values for xml:lang and
lang attributes.

Test: fast/css/lang-selector-empty-attribute.xhtml

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/lang-selector-empty-attribute-expected.txt (added)
• LayoutTests/fast/css/lang-selector-empty-attribute.xhtml (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSStyleSelector.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-15  Rob Buis  <rwlbuis@gmail.com>
+
+        Reviewed by Darin Adler.
+
+        Add test for:
+        An empty value for xml:lang isn't considered
+        https://bugs.webkit.org/show_bug.cgi?id=42042
+
+        * fast/css/lang-selector-empty-attribute-expected.txt: Added.
+        * fast/css/lang-selector-empty-attribute.xhtml: Added.
+
 2010-07-15  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-15  Rob Buis  <rwlbuis@gmail.com>
+
+        Reviewed by Darin Adler.
+
+        An empty value for xml:lang isn't considered
+        https://bugs.webkit.org/show_bug.cgi?id=42042
+
+        Allow :lang selector to match empty values for xml:lang and
+        lang attributes.
+
+        Test: fast/css/lang-selector-empty-attribute.xhtml
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+
 2010-07-16  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/WebCore/css/CSSStyleSelector.cpp

@@ -2601 +2601 @@
                 // The language property is inherited, so we iterate over the parents
                 // to find the first language.
-                while (n && value.isEmpty()) {
+                while (n && value.isNull()) {
                     if (n->isElementNode()) {
                         // Spec: xml:lang takes precedence -- http://www.w3.org/TR/xhtml1/#C_7
                         value = static_cast<Element*>(n)->fastGetAttribute(XMLNames::langAttr);
-                        if (value.isEmpty())
+                        if (value.isNull())
                             value = static_cast<Element*>(n)->fastGetAttribute(langAttr);
                     } else if (n->isDocumentNode())
@@ -2614 +2614 @@
                 }
                 const AtomicString& argument = sel->argument();
-                if (value.isEmpty() || !value.startsWith(argument, false))
+                if (value.isNull() || !value.startsWith(argument, false))
                     break;
                 if (value.length() != argument.length() && value[argument.length()] != '-')