Changeset 63572 in webkit

Timestamp:

Jul 16, 2010 12:45:50 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Spatial navigation: do not consider outline for focusable element boundaries
​https://bugs.webkit.org/show_bug.cgi?id=42474

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

Test: fast/events/spatial-navigation/snav-zero-margin-content.html

Currently in WebCore::renderRectRelativeToRootDocument function, we are calling
RenderObject::absoluteClippedOverflowRect to obtain the rect boundary of a given
renderer/element. This method deals with outline, which is out of elements boundary.
It makes spatial navigation to fail on common sites like google.gom: "Web, Images, Map, etc"
are inaccessible.

Patch replaces RenderObject::absoluteClippedOverflowRect by Node::getRect,
which returns only the absolute bounding box rect of the Element.

• page/SpatialNavigation.cpp:

(WebCore::renderRectRelativeToRootDocument):
(WebCore::checkNegativeCoordsForNode):

LayoutTests:

• fast/events/spatial-navigation/snav-zero-margin-content-expected.txt: Added.
• fast/events/spatial-navigation/snav-zero-margin-content.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/spatial-navigation/snav-zero-margin-content-expected.txt (added)
• LayoutTests/fast/events/spatial-navigation/snav-zero-margin-content.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/SpatialNavigation.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-16  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        Spatial navigation: do not consider outline for focusable element boundaries
+        https://bugs.webkit.org/show_bug.cgi?id=42474
+
+        * fast/events/spatial-navigation/snav-zero-margin-content-expected.txt: Added.
+        * fast/events/spatial-navigation/snav-zero-margin-content.html: Added.
+
 2010-07-16  Ojan Vafai  <ojan@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-16  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        Spatial navigation: do not consider outline for focusable element boundaries
+        https://bugs.webkit.org/show_bug.cgi?id=42474
+
+        Test: fast/events/spatial-navigation/snav-zero-margin-content.html
+
+        Currently in WebCore::renderRectRelativeToRootDocument function, we are calling
+        RenderObject::absoluteClippedOverflowRect to obtain the rect boundary of a given
+        renderer/element. This method deals with outline, which is out of elements boundary.
+        It makes spatial navigation to fail on common sites like google.gom: "Web, Images, Map, etc"
+        are inaccessible.
+
+        Patch replaces RenderObject::absoluteClippedOverflowRect by Node::getRect,
+        which returns only the absolute bounding box rect of the Element.
+
+        * page/SpatialNavigation.cpp:
+        (WebCore::renderRectRelativeToRootDocument):
+        (WebCore::checkNegativeCoordsForNode):
+
 2010-07-15  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebCore/page/SpatialNavigation.cpp

@@ -104 +104 @@
 static IntRect renderRectRelativeToRootDocument(RenderObject* render)
 {
-    ASSERT(render);
-
-    IntRect rect(render->absoluteClippedOverflowRect());
-
-    if (rect.isEmpty()) {
-        Element* e = static_cast<Element*>(render->node());
-        rect = e->getRect();
-    }
+    ASSERT(render && render->node());
+
+    IntRect rect = render->node()->getRect();
 
     // In cases when the |render|'s associated node is in a scrollable inner
@@ -518 +513 @@
     ASSERT(node || node->renderer());
 
-    if (curRect.x() > 0 && curRect.y() > 0)
+    if (curRect.x() >= 0 && curRect.y() >= 0)
         return true;