Changeset 63660 in webkit

Timestamp:

Jul 19, 2010 8:05:53 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-19 Robin Burchell <​robin.burchell@collabora.co.uk>

Reviewed by Antonio Gomes

[Qt] Use memcpy() instead of qMemCopy()
This is supposed to be more efficient, as the compiler is able to
optimise more.

Additionally, qMemCopy() is only strictly supposed to be used in
headers (see Qt's src/corelib/qglobal.h for reference)
See: ​https://bugs.webkit.org/show_bug.cgi?id=42392

• bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bridge/qt/qt_runtime.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-19  Robin Burchell  <robin.burchell@collabora.co.uk>
+
+        Reviewed by Antonio Gomes
+
+        [Qt] Use memcpy() instead of qMemCopy()
+        This is supposed to be more efficient, as the compiler is able to
+        optimise more.
+
+        Additionally,  qMemCopy() is only strictly supposed to be used in
+        headers (see Qt's src/corelib/qglobal.h for reference)
+        See: https://bugs.webkit.org/show_bug.cgi?id=42392
+
+        * bridge/qt/qt_runtime.cpp:
+        (JSC::Bindings::convertQVariantToValue):
+
 2010-07-14  Andreas Kling  <andreas.kling@nokia.com>
 

trunk/WebCore/bridge/qt/qt_runtime.cpp

@@ -870 +870 @@
         QByteArray qtByteArray = variant.value<QByteArray>();
         WTF::RefPtr<WTF::ByteArray> wtfByteArray = WTF::ByteArray::create(qtByteArray.length());
-        qMemCopy(wtfByteArray->data(), qtByteArray.constData(), qtByteArray.length());
+        memcpy(wtfByteArray->data(), qtByteArray.constData(), qtByteArray.length());
         return new (exec) JSC::JSByteArray(exec, JSC::JSByteArray::createStructure(jsNull()), wtfByteArray.get());
     }