Changeset 63746 in webkit

Timestamp:

Jul 20, 2010 8:17:25 AM (14 years ago)

Author:

yurys@chromium.org

Message:

2010-07-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page renderer crashes when inspected page has JS syntax error
​https://bugs.webkit.org/show_bug.cgi?id=42642

• bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8ConsoleMessage.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-20  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        [v8] Web Inspector: inspected page renderer crashes when inspected page has JS syntax error
+        https://bugs.webkit.org/show_bug.cgi?id=42642
+
+        * bindings/v8/V8ConsoleMessage.cpp:
+        (WebCore::V8ConsoleMessage::handler):
+
 2010-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/bindings/v8/V8ConsoleMessage.cpp

@@ -116 +116 @@
     OwnPtr<ScriptCallStack> callStack;
     // Currently stack trace is only collected when inspector is open.
-    if (!stackTrace.IsEmpty()) {
+    if (!stackTrace.IsEmpty() && stackTrace->GetFrameCount() > 0) {
         v8::Local<v8::Context> context = v8::Context::GetEntered();
         ScriptState* scriptState = ScriptState::forContext(context);