Changeset 63753 in webkit


Ignore:
Timestamp:
Jul 20, 2010 10:35:30 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-20 Leon Clarke <​leonclarke@google.com>

Reviewed by Pavel Feldman.

Make things compile again when the inspector is disabled, following
recent inspector improvements.
​https://bugs.webkit.org/show_bug.cgi?id=42632

No new tests. Fixing a build break.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • inspector/InspectorController.h: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
Location:
trunk/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r63751 r63753  
     12010-07-20  Leon Clarke  <leonclarke@google.com>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Make things compile again when the inspector is disabled, following
     6        recent inspector improvements.
     7        https://bugs.webkit.org/show_bug.cgi?id=42632
     8
     9        No new tests. Fixing a build break.
     10
     11
     12        * bindings/v8/ScriptCallStack.cpp:
     13        (WebCore::ScriptCallStack::stackTrace):
     14        * inspector/InspectorController.h:
     15        (WebCore::InspectorController::didInsertDOMNode):
     16        (WebCore::InspectorController::didRemoveDOMNode):
     17        (WebCore::InspectorController::didModifyDOMAttr):
     18        * inspector/InspectorDOMAgent.h:
     19        * loader/appcache/ApplicationCacheGroup.cpp:
     20
    1212010-07-20  Anton Muhin  <antonm@chromium.org>
    222

  • trunk/WebCore/bindings/v8/ScriptCallStack.cpp

    r63548 r63753  
    130130bool ScriptCallStack::stackTrace(int frameLimit, const RefPtr<InspectorArray>& stackTrace)
    131131{
     132#if ENABLE(INSPECTOR)
    132133    if (!v8::Context::InContext())
    133134        return false;
    … …  
    153154    }
    154155    return true;
     156#else
     157    return false;
     158#endif
    155159}
    156160

  • trunk/WebCore/inspector/InspectorController.h

    r63662 r63753  
    429429inline void InspectorController::didInsertDOMNode(Node* node)
    430430{
     431#if ENABLE(INSPECTOR)
    431432    if (m_domAgent)
    432433        m_domAgent->didInsertDOMNode(node);
     434#endif
    433435}
    434436
    435437inline void InspectorController::didRemoveDOMNode(Node* node)
    436438{
     439#if ENABLE(INSPECTOR)
    437440    if (m_domAgent)
    438441        m_domAgent->didRemoveDOMNode(node);
     442#endif
    439443}
    440444
    441445inline void InspectorController::didModifyDOMAttr(Element* element)
    442446{
     447#if ENABLE(INSPECTOR)
    443448    if (m_domAgent)
    444449        m_domAgent->didModifyDOMAttr(element);
     450#endif
    445451}
    446452

  • trunk/WebCore/inspector/InspectorDOMAgent.h

    r63309 r63753  
    5757    class Element;
    5858    class Event;
     59    class InspectorDOMAgent;
    5960    class RemoteInspectorFrontend;
    6061    class MatchJob;
    … …  
    6263    class Node;
    6364    class Page;
     65
     66#if ENABLE(INSPECTOR)
    6467
    6568    struct EventListenerInfo {
    … …  
    209212    };
    210213
     214#endif
     215
    211216} // namespace WebCore
    212217

  • trunk/WebCore/loader/appcache/ApplicationCacheGroup.cpp

    r63332 r63753  
    5050#include "InspectorController.h"
    5151#include "ProgressTracker.h"
     52#else
     53#include <wtf/UnusedParam.h>
    5254#endif
    5355
Note: See TracChangeset for help on using the changeset viewer.