Changeset 63759 in webkit


Ignore:
Timestamp:
Jul 20, 2010 11:12:10 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63750.
​http://trac.webkit.org/changeset/63750
​https://bugs.webkit.org/show_bug.cgi?id=42648

This revision breaks the windows builds (Requested by
hwennborg on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::Page::Page):

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63750.
​http://trac.webkit.org/changeset/63750
​https://bugs.webkit.org/show_bug.cgi?id=42648

This revision breaks the windows builds (Requested by
hwennborg on #webkit).

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r63757 r63759  
     12010-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r63750.
     4        http://trac.webkit.org/changeset/63750
     5        https://bugs.webkit.org/show_bug.cgi?id=42648
     6
     7        This revision breaks the windows builds (Requested by
     8        hwennborg on #webkit).
     9
     10        * bindings/generic/RuntimeEnabledFeatures.cpp:
     11        * bindings/generic/RuntimeEnabledFeatures.h:
     12        * page/DOMWindow.cpp:
     13        (WebCore::DOMWindow::addEventListener):
     14        (WebCore::DOMWindow::removeEventListener):
     15        (WebCore::DOMWindow::removeAllEventListeners):
     16        * page/DOMWindow.idl:
     17        * page/Page.cpp:
     18        (WebCore::Page::Page):
     19
    1202010-07-20  Ilya Tikhonovsky  <loislo@chromium.org>
    221

  • trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r63750 r63759  
    4848bool RuntimeEnabledFeatures::isPushStateEnabled = false;
    4949bool RuntimeEnabledFeatures::isTouchEnabled = true;
    50 bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
    5150
    5251#if ENABLE(VIDEO)

  • trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r63750 r63759  
    114114#endif
    115115
    116     static void setDeviceOrientationEnabled(bool isEnabled) { isDeviceOrientationEnabled = isEnabled; }
    117     static bool deviceOrientationEnabled() { return isDeviceOrientationEnabled; }
    118     static bool deviceOrientationEventEnabled() { return isDeviceOrientationEnabled; }
    119     static bool ondeviceorientationEnabled() { return isDeviceOrientationEnabled; }
    120 
    121116private:
    122117    // Never instantiate.
    … …  
    132127    static bool isPushStateEnabled;
    133128    static bool isTouchEnabled;
    134     static bool isDeviceOrientationEnabled;
    135129};
    136130

  • trunk/WebCore/page/DOMWindow.cpp

    r63750 r63759  
    14141414        addBeforeUnloadEventListener(this);
    14151415#if ENABLE(DEVICE_ORIENTATION)
    1416     else if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page() && frame()->page()->deviceOrientationController())
    1417         frame()->page()->deviceOrientationController()->addListener(this);
     1416    else if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page())
     1417        frame()->page()->deviceOrientation()->addListener(this);
    14181418#endif
    14191419
    … …  
    14311431        removeBeforeUnloadEventListener(this);
    14321432#if ENABLE(DEVICE_ORIENTATION)
    1433     else if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page() && frame()->page()->deviceOrientationController())
    1434         frame()->page()->deviceOrientationController()->removeListener(this);
     1433    else if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page())
     1434        frame()->page()->deviceOrientation()->removeListener(this);
    14351435#endif
    14361436
    … …  
    15091509
    15101510#if ENABLE(DEVICE_ORIENTATION)
    1511     if (frame() && frame()->page() && frame()->page()->deviceOrientationController())
    1512         frame()->page()->deviceOrientationController()->removeAllListeners(this);
     1511    if (frame() && frame()->page())
     1512        frame()->page()->deviceOrientation()->removeAllListeners(this);
    15131513#endif
    15141514

  • trunk/WebCore/page/DOMWindow.idl

    r63750 r63759  
    305305        attribute [Conditional=TOUCH_EVENTS,EnabledAtRuntime] EventListener ontouchcancel;
    306306
    307         attribute [Conditional=DEVICE_ORIENTATION, EnabledAtRuntime] DeviceOrientationEventConstructor DeviceOrientationEvent;
    308         attribute [Conditional=DEVICE_ORIENTATION, EnabledAtRuntime] EventListener ondeviceorientation;
     307        attribute [Conditional=DEVICE_ORIENTATION] DeviceOrientationEventConstructor DeviceOrientationEvent;
     308        attribute [Conditional=DEVICE_ORIENTATION] EventListener ondeviceorientation;
    309309
    310310        // EventTarget interface

  • trunk/WebCore/page/Page.cpp

    r63750 r63759  
    5858#include "RenderTheme.h"
    5959#include "RenderWidget.h"
    60 #include "RuntimeEnabledFeatures.h"
    6160#include "ScriptController.h"
    6261#include "SelectionController.h"
    … …  
    141140#endif
    142141#if ENABLE(DEVICE_ORIENTATION)
    143     , m_deviceOrientationController(RuntimeEnabledFeatures::deviceOrientationEnabled() ? new DeviceOrientationController(this, deviceOrientationClient) : 0)
     142    , m_deviceOrientationController(new DeviceOrientationController(this, deviceOrientationClient))
    144143#endif
    145144#if ENABLE(INPUT_SPEECH)

  • trunk/WebKit/chromium/ChangeLog

    r63755 r63759  
     12010-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r63750.
     4        http://trac.webkit.org/changeset/63750
     5        https://bugs.webkit.org/show_bug.cgi?id=42648
     6
     7        This revision breaks the windows builds (Requested by
     8        hwennborg on #webkit).
     9
     10        * public/WebRuntimeFeatures.h:
     11        * src/WebRuntimeFeatures.cpp:
     12
    1132010-07-19  Victor Wang  <victorw@chromium.org>
    214

  • trunk/WebKit/chromium/public/WebRuntimeFeatures.h

    r63750 r63759  
    7878    WEBKIT_API static bool isTouchEnabled();
    7979
    80     WEBKIT_API static void enableDeviceOrientation(bool);
    81     WEBKIT_API static bool isDeviceOrientationEnabled();
    82 
    8380private:
    8481    WebRuntimeFeatures();

  • trunk/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r63750 r63759  
    227227}
    228228
    229 void WebRuntimeFeatures::enableDeviceOrientation(bool enable)
    230 {
    231     RuntimeEnabledFeatures::setDeviceOrientationEnabled(enable);
    232 }
    233 
    234 bool WebRuntimeFeatures::isDeviceOrientationEnabled()
    235 {
    236     return RuntimeEnabledFeatures::deviceOrientationEnabled();
    237 }
    238 
    239229} // namespace WebKit
Note: See TracChangeset for help on using the changeset viewer.