Changeset 63779 in webkit

Timestamp:

Jul 20, 2010 3:12:17 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fix fast/dom/title-content-write-set.html for HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42668

When I split parserAppendData from appendData, it was tempting to cut
the function at dispatchModifiedEvent, but that's not quite right. We
still need to notify the parent that it's children have changed.

• dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
• dom/CharacterData.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/CharacterData.cpp (modified) (2 diffs)
• dom/CharacterData.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Fix fast/dom/title-content-write-set.html for HTML5 tree builder
+        https://bugs.webkit.org/show_bug.cgi?id=42668
+
+        When I split parserAppendData from appendData, it was tempting to cut
+        the function at dispatchModifiedEvent, but that's not quite right.  We
+        still need to notify the parent that it's children have changed.
+
+        * dom/CharacterData.cpp:
+        (WebCore::CharacterData::appendDataCommon):
+        (WebCore::CharacterData::parserAppendData):
+        (WebCore::CharacterData::appendData):
+        * dom/CharacterData.h:
+
 2010-07-20  Chris Fleizach  <cfleizach@apple.com>
 

trunk/WebCore/dom/CharacterData.cpp

@@ -60 +60 @@
 }
 
-PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg)
+PassRefPtr<StringImpl> CharacterData::appendDataCommon(const String& arg)
 {
     String newStr = m_data;
@@ -77 +77 @@
 }
 
+void CharacterData::parserAppendData(const String& arg)
+{
+    appendDataCommon(arg);
+    // We don't call dispatchModifiedEvent here because we don't want the
+    // parser to dispatch DOM mutation events.
+    if (parentNode())
+        parentNode()->childrenChanged();
+}
+
 void CharacterData::appendData(const String& arg, ExceptionCode&)
 {
-    RefPtr<StringImpl> oldStr = parserAppendData(arg);
+    RefPtr<StringImpl> oldStr = appendDataCommon(arg);
     dispatchModifiedEvent(oldStr.get());
 }

trunk/WebCore/dom/CharacterData.h

@@ -44 +44 @@
 
     // Like appendData, but optimized for the parser (e.g., no mutation events).
-    PassRefPtr<StringImpl> parserAppendData(const String&);
+    void parserAppendData(const String&);
 
 protected:
@@ -67 +67 @@
 
     void checkCharDataOperation(unsigned offset, ExceptionCode&);
+    PassRefPtr<StringImpl> appendDataCommon(const String& arg);
 
     RefPtr<StringImpl> m_data;