Changeset 63888 in webkit


Ignore:
Timestamp:
Jul 22, 2010 7:07:18 AM (14 years ago)
Author:
benm@google.com
Message:

2010-07-22 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Touch events do not affect the :active CSS state
​https://bugs.webkit.org/show_bug.cgi?id=39493

Clean the code up by using a typedef based on comments
post landing of the original patch.

No change in functionality so no new tests.

  • rendering/HitTestRequest.h: Typedef the HitTestRequestType to unsigned.
  • WebCore.exp.in: Update export signature.
  • WebCore.order: Ditto.
  • page/EventHandler.cpp: use the new typedef.
  • page/EventHandler.h: ditto.
Location:
trunk/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r63886 r63888  
     12010-07-22  Ben Murdoch  <benm@google.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Touch events do not affect the :active CSS state
     6        https://bugs.webkit.org/show_bug.cgi?id=39493
     7
     8        Clean the code up by using a typedef based on comments
     9        post landing of the original patch.
     10
     11        No change in functionality so no new tests.
     12
     13        * rendering/HitTestRequest.h: Typedef the HitTestRequestType to unsigned.
     14        * WebCore.exp.in: Update export signature.
     15        * WebCore.order: Ditto.
     16        * page/EventHandler.cpp: use the new typedef.
     17        * page/EventHandler.h: ditto.
     18
     19
    1202010-07-22  Alexander Pavlov  <apavlov@chromium.org>
    221

  • trunk/WebCore/WebCore.exp.in

    r63863 r63888  
    217217__ZN7WebCore12EventHandler16handleWheelEventERNS_18PlatformWheelEventE
    218218__ZN7WebCore12EventHandler20handleTextInputEventERKNS_6StringEPNS_5EventEbb
    219 __ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_8IntPointEbbNS_17HitTestScrollbarsEi
     219__ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_8IntPointEbbNS_17HitTestScrollbarsEj
    220220__ZN7WebCore12EventHandler21handleMousePressEventERKNS_18PlatformMouseEventE
    221221__ZN7WebCore12EventHandler23handleMouseReleaseEventERKNS_18PlatformMouseEventE

  • trunk/WebCore/WebCore.order

    r63807 r63888  
    30003000__ZNK7WebCore14RenderThemeMac20supportsControlTintsEv
    30013001__ZN7WebCore15GraphicsContext23setUpdatingControlTintsEb
    3002 __ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_8IntPointEbbNS_17HitTestScrollbarsEi
     3002__ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_8IntPointEbbNS_17HitTestScrollbarsEj
    30033003__ZNK7WebCore13HitTestResult10isSelectedEv
    30043004__ZN7WebCore19SelectionController8containsERKNS_8IntPointE

  • trunk/WebCore/page/EventHandler.cpp

    r63807 r63888  
    863863#endif // ENABLE(DRAG_SUPPORT)
    864864   
    865 HitTestResult EventHandler::hitTestResultAtPoint(const IntPoint& point, bool allowShadowContent, bool ignoreClipping, HitTestScrollbars testScrollbars, int hitType)
     865HitTestResult EventHandler::hitTestResultAtPoint(const IntPoint& point, bool allowShadowContent, bool ignoreClipping, HitTestScrollbars testScrollbars, HitTestRequest::HitTestRequestType hitType)
    866866{
    867867    HitTestResult result(point);
    … …  
    14391439    // This means that :hover and :active freeze in the state they were in when the mouse
    14401440    // was pressed, rather than updating for nodes the mouse moves over as you hold the mouse down.
    1441     int hitType = HitTestRequest::MouseMove;
     1441    HitTestRequest::HitTestRequestType hitType = HitTestRequest::MouseMove;
    14421442    if (m_mousePressed && m_mouseDownMayStartSelect)
    14431443        hitType |= HitTestRequest::ReadOnly;
    … …  
    28482848        IntPoint pagePoint = documentPointForWindowPoint(m_frame, point.pos());
    28492849
    2850         int hitType = HitTestRequest::Active | HitTestRequest::ReadOnly;
     2850        HitTestRequest::HitTestRequestType hitType = HitTestRequest::Active | HitTestRequest::ReadOnly;
    28512851        // The HitTestRequest types used for mouse events map quite adequately
    28522852        // to touch events. Note that in addition to meaning that the hit test

  • trunk/WebCore/page/EventHandler.h

    r63807 r63888  
    107107    void dispatchFakeMouseMoveEventSoonInQuad(const FloatQuad&);
    108108
    109     HitTestResult hitTestResultAtPoint(const IntPoint&, bool allowShadowContent, bool ignoreClipping = false, HitTestScrollbars scrollbars = DontHitTestScrollbars, int hitType = HitTestRequest::ReadOnly | HitTestRequest::Active);
     109    HitTestResult hitTestResultAtPoint(const IntPoint&, bool allowShadowContent, bool ignoreClipping = false, HitTestScrollbars scrollbars = DontHitTestScrollbars, HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active);
    110110
    111111    bool mousePressed() const { return m_mousePressed; }

  • trunk/WebCore/rendering/HitTestRequest.h

    r60761 r63888  
    3636    };
    3737
    38     HitTestRequest(int requestType)
     38    typedef unsigned HitTestRequestType;
     39
     40    HitTestRequest(HitTestRequestType requestType)
    3941        : m_requestType(requestType)
    4042    {
    … …  
    4951
    5052private:
    51     int m_requestType;
     53    HitTestRequestType m_requestType;
    5254};
    5355
Note: See TracChangeset for help on using the changeset viewer.