Changeset 63901 in webkit

Timestamp:

Jul 22, 2010 10:48:36 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-22 Joone Hur <​joone.hur@samsung.com>

Reviewed by Antonio Gomes.

[EFL] add support for logging
​https://bugs.webkit.org/show_bug.cgi?id=40807

Enable to turn log channels on for EFL port

• platform/efl/LoggingEfl.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/efl/LoggingEfl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-22  Joone Hur  <joone.hur@samsung.com>
+
+        Reviewed by Antonio Gomes.
+
+        [EFL] add support for logging
+        https://bugs.webkit.org/show_bug.cgi?id=40807
+
+        Enable to turn log channels on for EFL port
+
+        * platform/efl/LoggingEfl.cpp:
+        (WebCore::InitializeLoggingChannelsIfNecessary):
+
 2010-07-22  Balazs Kelemen  <kb@inf.u-szeged.hu>
 

trunk/WebCore/platform/efl/LoggingEfl.cpp

@@ -24 +24 @@
 #include "Logging.h"
 
+#include "PlatformString.h"
+#include <Eina.h>
+
 namespace WebCore {
 
 void InitializeLoggingChannelsIfNecessary()
 {
+    static bool didInitializeLoggingChannels = false;
+    if (didInitializeLoggingChannels)
+        return;
+
+    didInitializeLoggingChannels = true;
+
+    char* logEnv = getenv("WEBKIT_DEBUG");
+    if (!logEnv)
+        return;
+
+#if defined(NDEBUG)
+    EINA_LOG_WARN("WEBKIT_DEBUG is not empty, but this is a release build. Notice that many log messages will only appear in a debug build.");
+#endif
+
+    char** logv = eina_str_split(logEnv, ",", -1);
+
+    EINA_SAFETY_ON_NULL_RETURN(logv);
+
+    for (int i = 0; logv[i]; i++) {
+        if (WTFLogChannel* channel = getChannelFromName(logv[i]))
+            channel->state = WTFLogChannelOn;
+    }
+
+    free(*logv);
+    free(logv);
+
+    // To disable logging notImplemented set the DISABLE_NI_WARNING
+    // environment variable to 1.
     LogNotYetImplemented.state = WTFLogChannelOn;
 }