Changeset 63929 in webkit

Timestamp:

Jul 22, 2010 5:43:29 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-07-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Ojan Vafai.

Cancel button of search input field should fire input/change events
​https://bugs.webkit.org/show_bug.cgi?id=34393

• fast/forms/script-tests/search-cancel-button-events.js: Added.
• fast/forms/search-cancel-button-events-expected.txt: Added.
• fast/forms/search-cancel-button-events.html: Added.

2010-07-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Ojan Vafai.

Cancel button of search input field should fire input/change events
​https://bugs.webkit.org/show_bug.cgi?id=34393

Test: fast/forms/search-cancel-button-events.html

• rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/script-tests/search-cancel-button-events.js (added)
• LayoutTests/fast/forms/search-cancel-button-events-expected.txt (added)
• LayoutTests/fast/forms/search-cancel-button-events.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/TextControlInnerElements.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-22  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        Cancel button of search input field should fire input/change events
+        https://bugs.webkit.org/show_bug.cgi?id=34393
+
+        * fast/forms/script-tests/search-cancel-button-events.js: Added.
+        * fast/forms/search-cancel-button-events-expected.txt: Added.
+        * fast/forms/search-cancel-button-events.html: Added.
+
 2010-07-22  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-22  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        Cancel button of search input field should fire input/change events
+        https://bugs.webkit.org/show_bug.cgi?id=34393
+
+        Test: fast/forms/search-cancel-button-events.html
+
+        * rendering/TextControlInnerElements.cpp:
+        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
+
 2010-07-22  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/rendering/TextControlInnerElements.cpp

@@ -233 +233 @@
             }
             if (hovered()) {
+                RefPtr<HTMLInputElement> protector(input);
+                String oldValue = input->value();
                 input->setValue("");
+                if (!oldValue.isEmpty()) {
+                    toRenderTextControl(input->renderer())->setChangedSinceLastChangeEvent(true);
+                    input->dispatchEvent(Event::create(eventNames().inputEvent, true, false));
+                }
                 input->onSearch();
                 event->setDefaultHandled();