Changeset 64209 in webkit

Timestamp:

Jul 28, 2010 9:27:28 AM (14 years ago)

Author:

andreip@google.com

Message:

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
​https://bugs.webkit.org/show_bug.cgi?id=43120

• storage/indexeddb/script-tests/objectstore-basics.js: (openSuccess): (createSuccess):

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
​https://bugs.webkit.org/show_bug.cgi?id=43120

Makes the default WebKit::WebDOMStringList ctor actually create its wrapped
WebCore::DOMStringList instance.

• public/WebDOMStringList.h:
• src/WebDOMStringList.cpp: (WebKit::WebDOMStringList::WebDOMStringList):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebDOMStringList.h (modified) (1 diff)
• WebKit/chromium/src/WebDOMStringList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-28  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Jeremy Orlow.
+
+        [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
+        variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
+        https://bugs.webkit.org/show_bug.cgi?id=43120
+
+        * storage/indexeddb/script-tests/objectstore-basics.js:
+        (openSuccess):
+        (createSuccess):
+
 2010-07-28  Xianzhu Wang  <phnixwxz@gmail.com>
 

trunk/LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js

@@ -15 +15 @@
     debug("openSuccess():");
     verifySuccessEvent(event);
-    var db = evalAndLog("db = event.result");
+    db = evalAndLog("db = event.result");
 
     // FIXME: remove any previously created object stores.
@@ -31 +31 @@
     verifySuccessEvent(event);
     var store = evalAndLog("store = event.result");
+    var storeNames = evalAndLog("storeNames = db.objectStores");
 
     shouldBeEqualToString("store.name", "storeName");
     shouldBeNull("store.keyPath");
+    shouldBe("storeNames.contains('storeName')", "true");
+    shouldBe("storeNames.length", "1");
     // FIXME: test store.indexNames, as well as all object store's methods.
 

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-28  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Jeremy Orlow.
+
+        [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
+        variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
+        https://bugs.webkit.org/show_bug.cgi?id=43120
+
+        Makes the default WebKit::WebDOMStringList ctor actually create its wrapped
+        WebCore::DOMStringList instance.
+
+        * public/WebDOMStringList.h:
+        * src/WebDOMStringList.cpp:
+        (WebKit::WebDOMStringList::WebDOMStringList):
+
 2010-07-26  Steve Block  <steveblock@google.com>
 

trunk/WebKit/chromium/public/WebDOMStringList.h

@@ -47 +47 @@
     ~WebDOMStringList() { reset(); }
 
-    WebDOMStringList() { }
+    WebDOMStringList();
     WebDOMStringList(const WebDOMStringList& l) { assign(l); }
     WebDOMStringList& operator=(const WebDOMStringList& l)

trunk/WebKit/chromium/src/WebDOMStringList.cpp

@@ -38 +38 @@
 
 namespace WebKit {
+
+WebDOMStringList::WebDOMStringList()
+{
+    m_private = WebCore::DOMStringList::create();
+}
 
 void WebDOMStringList::reset()