Changeset 64505 in webkit

Timestamp:

Aug 2, 2010 4:43:04 PM (14 years ago)

Author:

xan@webkit.org

Message:

2010-08-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for the Audio element in the DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=43313

Add new files to the build.

• GNUmakefile.am:

WebCore:

2010-08-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for the Audio element in the DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=43313

The IDL definition of some HTMLMediaElement methods does not match
the C++ implementation API, take this fact into account when
generating the bindings.

• bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createAudioWrapper): (WebKit::createHTMLElementWrapper):
• bindings/scripts/CodeGeneratorGObject.pm:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.am (modified) (7 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp (modified) (4 diffs)
• WebCore/bindings/scripts/CodeGeneratorGObject.pm (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2010-08-02  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        [GTK] Add support for the Audio element in the DOM bindings
+        https://bugs.webkit.org/show_bug.cgi?id=43313
+
+        Add new files to the build.
+
+        * GNUmakefile.am:
+
 2010-08-02  Chris Fleizach  <cfleizach@apple.com>
 

trunk/GNUmakefile.am

@@ -376 +376 @@
         DerivedSources/webkit/WebKitDOMHTMLAppletElement.h \
         DerivedSources/webkit/WebKitDOMHTMLAreaElement.h \
+        DerivedSources/webkit/WebKitDOMHTMLAudioElement.h \
         DerivedSources/webkit/WebKitDOMHTMLBaseElement.h \
         DerivedSources/webkit/WebKitDOMHTMLBaseFontElement.h \
@@ -409 +410 @@
         DerivedSources/webkit/WebKitDOMHTMLMapElement.h \
         DerivedSources/webkit/WebKitDOMHTMLMarqueeElement.h \
+        DerivedSources/webkit/WebKitDOMHTMLMediaElement.h \
         DerivedSources/webkit/WebKitDOMHTMLMenuElement.h \
         DerivedSources/webkit/WebKitDOMHTMLMetaElement.h \
@@ -433 +435 @@
         DerivedSources/webkit/WebKitDOMHTMLTableRowElement.h \
         DerivedSources/webkit/WebKitDOMHTMLUListElement.h \
+        DerivedSources/webkit/WebKitDOMMediaError.h \
+        DerivedSources/webkit/WebKitDOMTimeRanges.h \
         DerivedSources/webkit/WebKitDOMValidityState.h \
         DerivedSources/webkit/WebKitDOMDOMApplicationCache.h \
@@ -537 +541 @@
         DerivedSources/webkit/WebKitDOMHTMLAreaElement.cpp \
         DerivedSources/webkit/WebKitDOMHTMLAreaElementPrivate.h \
+        DerivedSources/webkit/WebKitDOMHTMLAudioElement.cpp \
+        DerivedSources/webkit/WebKitDOMHTMLAudioElementPrivate.h \
         DerivedSources/webkit/WebKitDOMHTMLBaseElement.cpp \
         DerivedSources/webkit/WebKitDOMHTMLBaseElementPrivate.h \
@@ -603 +609 @@
         DerivedSources/webkit/WebKitDOMHTMLMarqueeElement.cpp \
         DerivedSources/webkit/WebKitDOMHTMLMarqueeElementPrivate.h \
+        DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp \
+        DerivedSources/webkit/WebKitDOMHTMLMediaElementPrivate.h \
         DerivedSources/webkit/WebKitDOMHTMLMenuElement.cpp \
         DerivedSources/webkit/WebKitDOMHTMLMenuElementPrivate.h \
@@ -653 +661 @@
         DerivedSources/webkit/WebKitDOMLocation.cpp \
         DerivedSources/webkit/WebKitDOMLocationPrivate.h \
+        DerivedSources/webkit/WebKitDOMMediaError.cpp \
+        DerivedSources/webkit/WebKitDOMMediaErrorPrivate.h \
         DerivedSources/webkit/WebKitDOMMediaList.cpp \
         DerivedSources/webkit/WebKitDOMMediaListPrivate.h \
@@ -688 +698 @@
         DerivedSources/webkit/WebKitDOMText.cpp \
         DerivedSources/webkit/WebKitDOMTextPrivate.h \
+        DerivedSources/webkit/WebKitDOMTimeRanges.cpp \
+        DerivedSources/webkit/WebKitDOMTimeRangesPrivate.h \
         DerivedSources/webkit/WebKitDOMTreeWalker.cpp \
         DerivedSources/webkit/WebKitDOMTreeWalkerPrivate.h \

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-02  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        [GTK] Add support for the Audio element in the DOM bindings
+        https://bugs.webkit.org/show_bug.cgi?id=43313
+
+        The IDL definition of some HTMLMediaElement methods does not match
+        the C++ implementation API, take this fact into account when
+        generating the bindings.
+
+        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
+        (WebKit::createAudioWrapper):
+        (WebKit::createHTMLElementWrapper):
+        * bindings/scripts/CodeGeneratorGObject.pm:
+
 2010-08-02  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp

@@ -38 +38 @@
 #include "HTMLAppletElement.h"
 #include "HTMLAreaElement.h"
+#include "HTMLAudioElement.h"
 #include "HTMLBRElement.h"
 #include "HTMLBaseElement.h"
@@ -96 +97 @@
 #include "webkit/WebKitDOMHTMLAppletElementPrivate.h"
 #include "webkit/WebKitDOMHTMLAreaElementPrivate.h"
+#include "webkit/WebKitDOMHTMLAudioElementPrivate.h"
 #include "webkit/WebKitDOMHTMLBRElementPrivate.h"
 #include "webkit/WebKitDOMHTMLBaseElementPrivate.h"
@@ -176 +178 @@
 }
 
+static gpointer createAudioWrapper(PassRefPtr<HTMLElement> element)
+{
+    return wrapHTMLAudioElement(static_cast<HTMLAudioElement*>(element.get()));
+}
+
 static gpointer createBaseWrapper(PassRefPtr<HTMLElement> element)
 {
@@ -447 +454 @@
        map.set(aTag.localName().impl(), createAnchorWrapper);
        map.set(appletTag.localName().impl(), createAppletWrapper);
+       map.set(audioTag.localName().impl(), createAudioWrapper);
        map.set(areaTag.localName().impl(), createAreaWrapper);
        map.set(baseTag.localName().impl(), createBaseWrapper);

trunk/WebCore/bindings/scripts/CodeGeneratorGObject.pm

@@ -823 +823 @@
     }
 
+    # Not quite sure what to do with this yet, but we need to take into
+    # account the difference in parameters between the IDL file and the
+    # actual implementation.
+    if ($function->signature->extendedAttributes->{"NeedsUserGestureCheck"}) {
+        $functionSig .= ", gboolean isUserGesture";
+        $callImplParams .= ", " if $callImplParams;
+        $callImplParams .= "false";
+    }
+
     if ($returnType ne "void" && $returnValueIsGDOMType && $functionSigType ne "DOMObject") {
         if ($functionSigType ne "EventTarget") {