Changeset 64603 in webkit


Ignore:
Timestamp:
Aug 3, 2010 3:56:17 PM (14 years ago)
Author:
jhoneycutt@apple.com
Message:

WebKitTestRunner needs to activate the Mac font ascent hack
​https://bugs.webkit.org/show_bug.cgi?id=43404

Reviewed by Darin Adler.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleActivateMacFontAscentHack):
Get the InjectedBundle, and calls its activateMacFontAscentHack().

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Declare WKBundleActivateMacFontAscentHack().

  • WebProcess/InjectedBundle/InjectedBundle.h:

Declare activateMacFontAscentHack().

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack):
Stubbed.

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack):
Stubbed.

  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack):
Activate the ascent hack.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
Call WKBundleActivateMacFontAscentHack().

Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit2/ChangeLog

    r64599 r64603  
     12010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        WebKitTestRunner needs to activate the Mac font ascent hack
     4        https://bugs.webkit.org/show_bug.cgi?id=43404
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
     9        (WKBundleActivateMacFontAscentHack):
     10        Get the InjectedBundle, and calls its activateMacFontAscentHack().
     11
     12        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
     13        Declare WKBundleActivateMacFontAscentHack().
     14
     15        * WebProcess/InjectedBundle/InjectedBundle.h:
     16        Declare activateMacFontAscentHack().
     17
     18        * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
     19        (WebKit::InjectedBundle::activateMacFontAscentHack):
     20        Stubbed.
     21
     22        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
     23        (WebKit::InjectedBundle::activateMacFontAscentHack):
     24        Stubbed.
     25
     26        * WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
     27        (WebKit::InjectedBundle::activateMacFontAscentHack):
     28        Activate the ascent hack.
     29
    1302010-08-03  Simon Fraser  <simon.fraser@apple.com>
    231

  • trunk/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp

    r64396 r64603  
    5858    toWK(bundleRef)->removeAllVisitedLinks();
    5959}
     60
     61void WKBundleActivateMacFontAscentHack(WKBundleRef bundleRef)
     62{
     63    toWK(bundleRef)->activateMacFontAscentHack();
     64}

  • trunk/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h

    r64067 r64603  
    3636WK_EXPORT void WKBundleSetShouldTrackVisitedLinks(WKBundleRef bundle, bool shouldTrackVisitedLinks);
    3737WK_EXPORT void WKBundleRemoveAllVisitedLinks(WKBundleRef bundle);
     38WK_EXPORT void WKBundleActivateMacFontAscentHack(WKBundleRef bundle);
    3839
    3940#ifdef __cplusplus

  • trunk/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h

    r64396 r64603  
    7171    void setShouldTrackVisitedLinks(bool);
    7272    void removeAllVisitedLinks();
     73    void activateMacFontAscentHack();
    7374
    7475    // Callback hooks

  • trunk/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp

    r63825 r64603  
    8787}
    8888
     89void InjectedBundle::activateMacFontAscentHack()
     90{
     91}
     92
    8993} // namespace WebKit

  • trunk/WebKit2/WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp

    r62494 r64603  
    4040}
    4141
     42void InjectedBundle::activateMacFontAscentHack()
     43{
     44}
     45
    4246} // namespace WebKit

  • trunk/WebKit2/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp

    r61222 r64603  
    2828#include "WKBundleAPICast.h"
    2929#include "WKBundleInitialize.h"
     30#include <WebCore/SimpleFontData.h>
    3031
    3132#include <windows.h>
    … …  
    8081}
    8182
     83void InjectedBundle::activateMacFontAscentHack()
     84{
     85    SimpleFontData::setShouldApplyMacAscentHack(true);
     86}
     87
    8288} // namespace WebKit

  • trunk/WebKitTools/ChangeLog

    r64601 r64603  
     12010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        WebKitTestRunner needs to activate the Mac font ascent hack
     4        https://bugs.webkit.org/show_bug.cgi?id=43404
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
     9        (WTR::InjectedBundle::initialize):
     10        Call WKBundleActivateMacFontAscentHack().
     11
    1122010-08-03  Alex Milowski  <alex@milowski.com>
    213

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp

    r64485 r64603  
    8282
    8383    activateFonts();
     84    WKBundleActivateMacFontAscentHack(m_bundle);
    8485}
    8586
Note: See TracChangeset for help on using the changeset viewer.