Changeset 64643 in webkit
- Timestamp:
- Aug 4, 2010 5:38:33 AM (14 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r64640 r64643 1 2010-08-03 MORITA Hajime <morrita@google.com> 2 3 Reviewed by Tony Chang. 4 5 [DRT] Assertion failed when drag and move a draggable element. 6 https://bugs.webkit.org/show_bug.cgi?id=41695 7 8 * fast/events/dragging-mouse-moves-expected.txt: Added. 9 * fast/events/dragging-mouse-moves.html: Added. 10 1 11 2010-08-04 Steve Block <steveblock@google.com> 2 12 -
trunk/WebKitTools/ChangeLog
r64639 r64643 1 2010-08-03 MORITA Hajime <morrita@google.com> 2 3 Reviewed by Tony Chang. 4 5 [DRT] Assertion failed when drag and move a draggable element. 6 https://bugs.webkit.org/show_bug.cgi?id=41695 7 8 mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started. 9 But Cocoa doesn't call mouseDragged() until dragging is done. 10 Other part of DumpRenderTree also assumes Cocoa behavior and an assertion 11 on UIDelegate failed when mouseDragged() is called during dragging. 12 This change eliminated the mouseDragged() call when dragging begins, 13 which is implicated by draggingInfo instance. 14 15 * DumpRenderTree/mac/EventSendingController.mm: 16 (-[EventSendingController mouseMoveToX:Y:]): 17 18 Test: fast/events/dragging-mouse-moves.html 19 1 20 2010-08-02 Steve Block <steveblock@google.com> 2 21 -
trunk/WebKitTools/DumpRenderTree/mac/EventSendingController.mm
r64470 r64643 450 450 if (subView) { 451 451 if (leftMouseButtonDown) { 452 [subView mouseDragged:event];453 452 if (draggingInfo) { 454 453 // Per NSDragging.h: draggingSources may not implement draggedImage:movedTo: … … 456 455 [[draggingInfo draggingSource] draggedImage:[draggingInfo draggedImage] movedTo:lastMousePosition]; 457 456 [[mainFrame webView] draggingUpdated:draggingInfo]; 458 } 457 } else 458 [subView mouseDragged:event]; 459 459 } else 460 460 [subView mouseMoved:event];
Note: See TracChangeset
for help on using the changeset viewer.