Changeset 64705 in webkit

Timestamp:

Aug 4, 2010 8:27:56 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

2010-08-04 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Daniel Bates.

Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
​https://bugs.webkit.org/show_bug.cgi?id=43534

As pointed out by Steve Block in ​https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
the non-negative checks present in both paddingWidth and paddingHeight methods of
HitTestResults class are superflous, after we changed the rect based hit testing logic
of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.

No new tests needed.

• rendering/HitTestResult.h: (WebCore::HitTestResult::paddingWidth): (WebCore::HitTestResult::paddingHeight):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/HitTestResult.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Daniel Bates.
+
+        Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
+        https://bugs.webkit.org/show_bug.cgi?id=43534
+
+        As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
+        the non-negative checks present in both paddingWidth and paddingHeight methods of
+        HitTestResults class are superflous, after we changed the rect based hit testing logic
+        of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.
+
+        No new tests needed.
+
+        * rendering/HitTestResult.h:
+        (WebCore::HitTestResult::paddingWidth):
+        (WebCore::HitTestResult::paddingHeight):
+
 2010-08-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/rendering/HitTestResult.h

@@ -87 +87 @@
     IntRect rectFromPoint(const IntPoint&) const;
     IntSize padding() const { return m_padding; }
-    int paddingWidth() const { return m_padding.width() >= 0 ? m_padding.width() : 0; }
-    int paddingHeight() const { return m_padding.height() >= 0 ? m_padding.height() : 0; }
+    int paddingWidth() const { return m_padding.width(); }
+    int paddingHeight() const { return m_padding.height(); }
     // Returns true if it is rect-based hit test and needs to continue until the rect is fully
     // enclosed by the boundaries of a node.