Changeset 64808 in webkit


Ignore:
Timestamp:
Aug 5, 2010 6:23:00 PM (14 years ago)
Author:
rniwa@webkit.org
Message:

2010-08-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dumpAsMarkup conversion: deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
​https://bugs.webkit.org/show_bug.cgi?id=43580

Converted deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
to a dumpAsMarkup test because all the tests were testing the correctness of the resultant DOM tree.
In addition, removed editing delegates from execCommand/format-block-from-range-selection.html because it's not relevant to the test.

  • editing/deleting/delete-4038408-fix-expected.txt: Added.
  • editing/deleting/delete-4038408-fix.html: Converted.
  • editing/deleting/delete-br-011-expected.txt: Added.
  • editing/deleting/delete-br-011.html: Converted.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Converted.
  • platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
3 added
29 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r64806 r64808  
     12010-08-05  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        dumpAsMarkup conversion: deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
     6        https://bugs.webkit.org/show_bug.cgi?id=43580
     7
     8        Converted deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
     9        to a dumpAsMarkup test because all the tests were testing the correctness of the resultant DOM tree.
     10        In addition, removed editing delegates from execCommand/format-block-from-range-selection.html because it's not relevant to the test.
     11
     12        * editing/deleting/delete-4038408-fix-expected.txt: Added.
     13        * editing/deleting/delete-4038408-fix.html: Converted.
     14        * editing/deleting/delete-br-011-expected.txt: Added.
     15        * editing/deleting/delete-br-011.html: Converted.
     16        * editing/execCommand/format-block-from-range-selection-expected.txt: Added.
     17        * editing/execCommand/format-block-from-range-selection.html: Converted.
     18        * platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
     19        * platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.png: Removed.
     20        * platform/chromium-linux/editing/deleting/delete-br-011-expected.checksum: Removed.
     21        * platform/chromium-linux/editing/deleting/delete-br-011-expected.png: Removed.
     22        * platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
     23        * platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
     24        * platform/chromium-win/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
     25        * platform/chromium-win/editing/deleting/delete-4038408-fix-expected.png: Removed.
     26        * platform/chromium-win/editing/deleting/delete-4038408-fix-expected.txt: Removed.
     27        * platform/chromium-win/editing/deleting/delete-br-011-expected.checksum: Removed.
     28        * platform/chromium-win/editing/deleting/delete-br-011-expected.png: Removed.
     29        * platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Removed.
     30        * platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
     31        * platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
     32        * platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
     33        * platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
     34        * platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.png: Removed.
     35        * platform/mac/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
     36        * platform/mac/editing/deleting/delete-4038408-fix-expected.png: Removed.
     37        * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Removed.
     38        * platform/mac/editing/deleting/delete-br-011-expected.checksum: Removed.
     39        * platform/mac/editing/deleting/delete-br-011-expected.png: Removed.
     40        * platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
     41        * platform/mac/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
     42        * platform/mac/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
     43        * platform/mac/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
     44        * platform/qt/editing/deleting/delete-4038408-fix-expected.txt: Removed.
     45        * platform/qt/editing/deleting/delete-br-011-expected.txt: Removed.
     46        * platform/qt/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
     47
    1482010-08-05  Adam Barth  <abarth@webkit.org>
    249

  • trunk/LayoutTests/editing/deleting/delete-4038408-fix.html

    r14751 r64808  
    11<html>
    22<head>
    3 
    43<style>
    54.editing {
    … …  
    1312}
    1413</style>
     14<script src="../../resources/dump-as-markup.js"></script>
    1515<script src="../editing.js" language="JavaScript" type="text/JavaScript" ></script>
    1616
    … …  
    1818
    1919function editingTest() {
     20    Markup.description('rdar://problems/4038408&4154187&4125087&4125381, This tests deletion from underneath quoted text:');
     21
     22    Markup.dump('test', 'before deletion');
     23
     24    // Move the caret to the end of #test
    2025    selectAllCommand();
    2126    moveSelectionForwardByCharacterCommand();
     27
     28    // Delete the reply text
    2229    deleteCommand();
    2330    deleteCommand();
    2431    deleteCommand();
    2532    deleteCommand();
    26    
     33    Markup.dump('test', 'after deletion');
     34
    2735    insertNewlineInQuotedContentCommand();
    28    
    2936    document.execCommand("InsertText", false, "This text should not be quoted.");
     37
     38    Markup.dump('test', 'after insert text');
    3039}
    3140
    … …  
    3544</head>
    3645<body>
     46<p>Radar: <a href="rdar://problems/4038408&4154187&4125087&4125381">rdar://problems/4038408&4154187&4125087&4125381</a>
     47Deletion of reply text should not produce reply text style unless the caret is inside the reply text blockquote.</p>
     48<p>This tests deletion from underneath quoted text:</p>
    3749<div contenteditable id="test" class="editing">
    38 <div>Radar: <a href="rdar://problems/4038408&4154187&4125087&4125381">rdar://problems/4038408&4154187&4125087&4125381</a></div>
    39 <div>Deletion of reply text should not produce reply text style unless the caret is inside the reply text blockquote.</div>
    40 <div><BR class="khtml-block-placeholder"></div>
    41 <div>This tests deletion from underneath quoted text:</div>
    4250<div><BR class="khtml-block-placeholder"></div>
    4351<div>

  • trunk/LayoutTests/editing/deleting/delete-br-011.html

    r11995 r64808  
    11<html>
    22<head>
    3 
    43<style>
    54.editing {
    … …  
    98}
    109</style>
    11 <script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>
    12 
     10<script src="../../resources/dump-as-markup.js"></script>
     11<script src="../editing.js"></script>
    1312<script>
    1413
     14Markup.waitUntilDone();
     15
    1516function editingTest() {
     17
     18    Markup.description('rdar://problem/4065343 Mail: Deleting a line sometimes makes the insertion point jump to the top of the message.');
     19    Markup.dump('root', 'before deletion');
     20
    1621    for (i = 0; i < 5; i++)
    1722        moveSelectionForwardByLineCommand();
    1823    deleteCommand();
     24
     25    Markup.dump('root', 'after deletion');
     26    Markup.notifyDone();
    1927}
    2028
    2129</script>
    22 
    2330<title>Editing Test</title>
    2431</head>

  • trunk/LayoutTests/editing/execCommand/format-block-from-range-selection.html

    r17562 r64808  
    1 <script>
    2 if (window.layoutTestController)
    3      layoutTestController.dumpEditingCallbacks();
    4 </script>
     1<script src="../../resources/dump-as-markup.js"></script>
    52<div id="description">This test uses FormatBlock to apply the dl tag to a range of paragraphs with different block tags.</div>
    63<br>
    7 <div style="border:1px solid black" contenteditable="true">
     4<div id="test" style="border:1px solid black" contenteditable="true">
    85<pre id="start">Foo</pre>
    96<div>bar<br><span>baz</span><br>raz</div>
    … …  
    1916s.setBaseAndExtent(start, 2, end, 2);
    2017
     18Markup.description('This test uses FormatBlock to apply the dl tag to a range of paragraphs with different block tags.');
     19Markup.dump('test', 'before FormatBlock');
     20
    2121document.execCommand("FormatBlock", false, "dl");
     22
     23Markup.dump('test', 'after FormatBlock');
    2224</script>
Note: See TracChangeset for help on using the changeset viewer.