Changeset 64843 in webkit


Ignore:
Timestamp:
Aug 6, 2010 6:22:31 AM (14 years ago)
Author:
tkent@chromium.org
Message:

2010-08-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Should revoke scheduled tasks
​https://bugs.webkit.org/show_bug.cgi?id=43560

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
Location:
trunk/WebKitTools
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r64841 r64843  
     12010-08-06  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [DRT/Chromium] Should revoke scheduled tasks
     6        https://bugs.webkit.org/show_bug.cgi?id=43560
     7
     8        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
     9        (DRTDevToolsAgent::reset): Calls RevokeAll().
     10        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
     11        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
     12        (DRTDevToolsClient::reset): Calls RevokeAll().
     13        * DumpRenderTree/chromium/DRTDevToolsClient.h:
     14        * DumpRenderTree/chromium/EventSender.cpp:
     15        (EventSender::reset): Calls RevokeAll().
     16        * DumpRenderTree/chromium/LayoutTestController.cpp:
     17        (LayoutTestController::reset): Calls RevokeAll().
     18        * DumpRenderTree/chromium/TestShell.cpp:
     19        (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
     20
    1212010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    222

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp

    r64729 r64843  
    5353    if (m_routingID == 1)
    5454        WebDevToolsAgent::setMessageLoopDispatchHandler(&DRTDevToolsAgent::dispatchMessageLoop);
     55}
     56
     57void DRTDevToolsAgent::reset()
     58{
     59    m_callMethodFactory.RevokeAll();
    5560}
    5661

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.h

    r64729 r64843  
    5353    DRTDevToolsAgent();
    5454    virtual ~DRTDevToolsAgent() {}
     55    void reset();
    5556
    5657    void setWebView(WebKit::WebView*);

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp

    r64729 r64843  
    6565}
    6666
     67void DRTDevToolsClient::reset()
     68{
     69    m_callMethodFactory.RevokeAll();
     70}
     71
    6772void DRTDevToolsClient::sendFrontendLoaded() {
    6873    if (m_drtDevToolsAgent)

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.h

    r64729 r64843  
    5454    DRTDevToolsClient(DRTDevToolsAgent*, WebKit::WebView*);
    5555    virtual ~DRTDevToolsClient();
     56    void reset();
    5657
    5758    // WebDevToolsFrontendClient implementation

  • trunk/WebKitTools/DumpRenderTree/chromium/EventSender.cpp

    r64530 r64843  
    324324    touchModifiers = 0;
    325325    touchPoints.clear();
     326    m_methodFactory.RevokeAll();
    326327}
    327328

  • trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp

    r64749 r64843  
    515515        m_closeRemainingWindows = true;
    516516    m_workQueue.reset();
     517    m_timeoutFactory.RevokeAll();
    517518}
    518519

  • trunk/WebKitTools/DumpRenderTree/chromium/TestShell.cpp

    r64749 r64843  
    279279    m_webViewHost->reset();
    280280    m_notificationPresenter->reset();
     281    m_drtDevToolsAgent->reset();
     282    if (m_drtDevToolsClient)
     283        m_drtDevToolsClient->reset();
    281284}
    282285
Note: See TracChangeset for help on using the changeset viewer.