Changeset 64851 in webkit

Timestamp:

Aug 6, 2010 8:30:59 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-08-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: disable device motion by default.

​https://bugs.webkit.org/show_bug.cgi?id=43623

• public/WebRuntimeFeatures.h:
• src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceMotion): (WebKit::WebRuntimeFeatures::isDeviceMotionEnabled): (WebKit::WebRuntimeFeatures::enableDeviceOrientation):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebRuntimeFeatures.h (modified) (1 diff)
• src/WebRuntimeFeatures.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-08-06  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Chromium: disable device motion by default.
+
+        https://bugs.webkit.org/show_bug.cgi?id=43623
+
+        * public/WebRuntimeFeatures.h:
+        * src/WebRuntimeFeatures.cpp:
+        (WebKit::WebRuntimeFeatures::enableDeviceMotion):
+        (WebKit::WebRuntimeFeatures::isDeviceMotionEnabled):
+        (WebKit::WebRuntimeFeatures::enableDeviceOrientation):
+
 2010-08-06  Kavita Kanetkar  <kkanetkar@chromium.org>
 

trunk/WebKit/chromium/public/WebRuntimeFeatures.h

@@ -78 +78 @@
     WEBKIT_API static bool isTouchEnabled();
 
+    WEBKIT_API static void enableDeviceMotion(bool);
+    WEBKIT_API static bool isDeviceMotionEnabled();
+
     WEBKIT_API static void enableDeviceOrientation(bool);
     WEBKIT_API static bool isDeviceOrientationEnabled();

trunk/WebKit/chromium/src/WebRuntimeFeatures.cpp

@@ -227 +227 @@
 }
 
+void WebRuntimeFeatures::enableDeviceMotion(bool enable)
+{
+    RuntimeEnabledFeatures::setDeviceMotionEnabled(enable);
+}
+
+bool WebRuntimeFeatures::isDeviceMotionEnabled()
+{
+    return RuntimeEnabledFeatures::deviceMotionEnabled();
+}
+
 void WebRuntimeFeatures::enableDeviceOrientation(bool enable)
 {
     RuntimeEnabledFeatures::setDeviceOrientationEnabled(enable);
+    // TODO: fix once called downstream.
+    RuntimeEnabledFeatures::setDeviceMotionEnabled(false);
 }