Changeset 64912 in webkit

Timestamp:

Aug 7, 2010, 10:34:19 AM (15 years ago)

Author:

zherczeg@webkit.org

Message:

Bitmap.h has no default constructor
​https://bugs.webkit.org/show_bug.cgi?id=43619

Reviewed by Eric Seidel.

Without a constructor, the initial bits of the Bitmap class
are undefinied. If only a few, or zero bits are 0, the memory
area provided by AlignedMemoryAllocator can be easly exhausted.

Csaba Osztrogonác helped to find this bug.

• wtf/Bitmap.h:

(WTF::::Bitmap):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/Bitmap.h (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-08-07  Zoltan Herczeg  <zherczeg@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Bitmap.h has no default constructor
+        https://bugs.webkit.org/show_bug.cgi?id=43619
+
+        Without a constructor, the initial bits of the Bitmap class
+        are undefinied. If only a few, or zero bits are 0, the memory
+        area provided by AlignedMemoryAllocator can be easly exhausted.
+
+        Csaba Osztrogonác helped to find this bug.
+
+        * wtf/Bitmap.h:
+        (WTF::::Bitmap):
+
 2010-08-06  Rafael Antognolli  <antognolli@profusion.mobi>
 

trunk/JavaScriptCore/wtf/Bitmap.h

@@ -33 +33 @@
 
 public:
+    Bitmap();
+
     bool get(size_t) const;
     void set(size_t);
@@ -55 +57 @@
     FixedArray<WordType, words> bits;
 };
+
+template<size_t size>
+inline Bitmap<size>::Bitmap()
+{
+    clearAll();
+}
 
 template<size_t size>