Changeset 64921 in webkit
- Timestamp:
- Aug 7, 2010 2:42:06 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 17 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r64920 r64921 1 2010-08-07 Sam Weinig <sam@webkit.org> 2 3 Reviewed by Anders Carlsson. 4 5 WebKitTestRunner needs GCController 6 <rdar://problem/8213834> 7 https://bugs.webkit.org/show_bug.cgi?id=42701 8 9 * platform/mac-wk2/Skipped: Remove now passing tests and add some failing tests. 10 1 11 2010-08-07 Dan Bernstein <mitz@apple.com> 2 12 -
trunk/LayoutTests/platform/mac-wk2/Skipped
r64631 r64921 1591 1591 fast/dom/Geolocation/callback-to-remote-context.html 1592 1592 fast/dom/Geolocation/callback-to-remote-context2.html 1593 fast/dom/Geolocation/delayed-permission-allowed.html 1594 fast/dom/Geolocation/delayed-permission-denied.html 1593 1595 fast/dom/Geolocation/error.html 1594 1596 fast/dom/Geolocation/multiple-requests.html 1597 fast/dom/Geolocation/notimer-after-unload.html 1595 1598 fast/dom/Geolocation/permission-denied-already-clear-watch.html 1596 1599 fast/dom/Geolocation/permission-denied-already-error.html 1597 1600 fast/dom/Geolocation/permission-denied-already-success.html 1601 fast/dom/Geolocation/permission-denied-stops-watches.html 1598 1602 fast/dom/Geolocation/permission-denied.html 1599 fast/dom/Geolocation/permission-denied-stops-watches.html1600 1603 fast/dom/Geolocation/position-string.html 1601 1604 fast/dom/Geolocation/reentrant-error.html … … 1605 1608 fast/dom/Geolocation/timeout.html 1606 1609 fast/dom/Geolocation/watch.html 1607 fast/dom/Geolocation/notimer-after-unload.html1608 1610 1609 1611 # WebKitTestRunner needs layoutTestController.setMockGeolocationPosition … … 1791 1793 http/tests/cookies/third-party-cookie-relaxing.html 1792 1794 http/tests/plugins/third-party-cookie-accept-policy.html 1793 1794 # WebKitTestRunner needs GCController1795 # <https://bugs.webkit.org/show_bug.cgi?id=42701>1796 fast/dom/gc-10.html1797 fast/dom/StyleSheet/ownerNode-lifetime-2.html1798 fast/frames/removal-before-attach-crash.html1799 1795 1800 1796 # WebKitTestRunner needs to print onunload handler information … … 2120 2116 fast/loader/frame-creation-removal.html 2121 2117 fast/overflow/scroll-vertical-not-horizontal.html 2118 fast/parser/entities-in-xhtml.xhtml 2122 2119 http/tests/history/back-to-post.php 2123 2120 http/tests/media/video-load-twice.html … … 2140 2137 platform/mac/fast/loader/non-html-load-event.html 2141 2138 2142 2143 2139 ######################################## 2144 2140 -
trunk/WebKit2/ChangeLog
r64919 r64921 1 2010-08-07 Sam Weinig <sam@webkit.org> 2 3 Reviewed by Anders Carlsson. 4 5 WebKitTestRunner needs GCController 6 <rdar://problem/8213834> 7 https://bugs.webkit.org/show_bug.cgi?id=42701 8 9 * WebProcess/InjectedBundle/API/c/WKBundle.cpp: 10 (WKBundleGarbageCollectJavaScriptObjects): 11 (WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging): 12 (WKBundleGetJavaScriptObjectsCount): 13 * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: 14 * WebProcess/InjectedBundle/InjectedBundle.cpp: 15 (WebKit::InjectedBundle::garbageCollectJavaScriptObjects): 16 (WebKit::InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging): 17 (WebKit::InjectedBundle::javaScriptObjectsCount): 18 * WebProcess/InjectedBundle/InjectedBundle.h: 19 1 20 2010-08-07 Anders Carlsson <andersca@apple.com> 2 21 -
trunk/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
r64603 r64921 63 63 toWK(bundleRef)->activateMacFontAscentHack(); 64 64 } 65 66 void WKBundleGarbageCollectJavaScriptObjects(WKBundleRef bundleRef) 67 { 68 toWK(bundleRef)->garbageCollectJavaScriptObjects(); 69 } 70 71 void WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging(WKBundleRef bundleRef, bool waitUntilDone) 72 { 73 toWK(bundleRef)->garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging(waitUntilDone); 74 } 75 76 size_t WKBundleGetJavaScriptObjectsCount(WKBundleRef bundleRef) 77 { 78 return toWK(bundleRef)->javaScriptObjectsCount(); 79 } -
trunk/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
r64603 r64921 30 30 #include <WebKit2/WKBundleBase.h> 31 31 32 #ifndef __cplusplus 33 #include <stdbool.h> 34 #endif 35 32 36 #ifdef __cplusplus 33 37 extern "C" { … … 37 41 WK_EXPORT void WKBundleRemoveAllVisitedLinks(WKBundleRef bundle); 38 42 WK_EXPORT void WKBundleActivateMacFontAscentHack(WKBundleRef bundle); 43 WK_EXPORT void WKBundleGarbageCollectJavaScriptObjects(WKBundleRef bundle); 44 WK_EXPORT void WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging(WKBundleRef bundle, bool waitUntilDone); 45 WK_EXPORT size_t WKBundleGetJavaScriptObjectsCount(WKBundleRef bundle); 39 46 40 47 #ifdef __cplusplus -
trunk/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
r64877 r64921 28 28 #include "Arguments.h" 29 29 #include "ImmutableArray.h" 30 #include "WebContextMessageKinds.h"31 30 #include "InjectedBundleMessageKinds.h" 32 31 #include "WKAPICast.h" 33 32 #include "WKBundleAPICast.h" 33 #include "WebContextMessageKinds.h" 34 34 #include "WebCoreArgumentCoders.h" 35 35 #include "WebPage.h" 36 36 #include "WebProcess.h" 37 #include <JavaScriptCore/JSLock.h> 38 #include <WebCore/GCController.h> 39 #include <WebCore/JSDOMWindow.h> 37 40 #include <WebCore/PageGroup.h> 38 41 #include <wtf/OwnArrayPtr.h> 39 42 40 43 using namespace WebCore; 44 using namespace JSC; 41 45 42 46 namespace WebKit { … … 194 198 } 195 199 200 void InjectedBundle::garbageCollectJavaScriptObjects() 201 { 202 gcController().garbageCollectNow(); 203 } 204 205 void InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging(bool waitUntilDone) 206 { 207 gcController().garbageCollectOnAlternateThreadForDebugging(waitUntilDone); 208 } 209 210 size_t InjectedBundle::javaScriptObjectsCount() 211 { 212 JSLock lock(SilenceAssertionsOnly); 213 return JSDOMWindow::commonJSGlobalData()->heap.objectCount(); 214 } 215 196 216 void InjectedBundle::didCreatePage(WebPage* page) 197 217 { -
trunk/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
r64877 r64921 73 73 void activateMacFontAscentHack(); 74 74 75 // Garbage collection API 76 void garbageCollectJavaScriptObjects(); 77 void garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging(bool waitUntilDone); 78 size_t javaScriptObjectsCount(); 79 75 80 // Callback hooks 76 81 void didCreatePage(WebPage*); -
trunk/WebKitTools/ChangeLog
r64888 r64921 1 2010-08-07 Sam Weinig <sam@webkit.org> 2 3 Reviewed by Anders Carlsson. 4 5 WebKitTestRunner needs GCController 6 <rdar://problem/8213834> 7 https://bugs.webkit.org/show_bug.cgi?id=42701 8 9 * WebKitTestRunner/DerivedSources.make: 10 * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added. 11 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: 12 (WTR::setProperty): 13 * WebKitTestRunner/InjectedBundle/GCController.cpp: Added. 14 (WTR::GCController::create): 15 (WTR::GCController::GCController): 16 (WTR::GCController::~GCController): 17 (WTR::GCController::wrapperClass): 18 (WTR::GCController::collect): 19 (WTR::GCController::collectOnAlternateThread): 20 (WTR::GCController::getJSObjectCount): 21 (WTR::GCController::makeWindowObject): 22 * WebKitTestRunner/InjectedBundle/GCController.h: Added. 23 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 24 (WTR::InjectedBundle::reset): 25 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 26 (WTR::InjectedBundle::bundle): 27 (WTR::InjectedBundle::gcController): 28 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 29 (WTR::InjectedBundlePage::didClearWindowForFrame): 30 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 31 (WTR::LayoutTestController::keepWebHistory): 32 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 33 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 34 * WebKitTestRunner/win/InjectedBundle.vcproj: 35 1 36 2010-08-05 Jon Honeycutt <jhoneycutt@apple.com> 2 37 -
trunk/WebKitTools/WebKitTestRunner/DerivedSources.make
r63693 r64921 28 28 INTERFACES = \ 29 29 LayoutTestController \ 30 GCController \ 30 31 # 31 32 -
trunk/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h
r63693 r64921 28 28 29 29 #include "JSWrappable.h" 30 #include <JavaScriptCore/JSRetainPtr.h> 30 31 31 32 namespace WTR { … … 46 47 } 47 48 49 inline void setProperty(JSContextRef context, JSObjectRef object, const char* propertyName, JSWrappable* value, JSPropertyAttributes attributes, JSValueRef* exception) 50 { 51 JSRetainPtr<JSStringRef> propertyNameString(Adopt, JSStringCreateWithUTF8CString(propertyName)); 52 JSObjectSetProperty(context, object, propertyNameString.get(), JSWrapper::wrap(context, value), attributes, exception); 53 } 54 48 55 } // namespace WTR 49 56 -
trunk/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
r64603 r64921 135 135 m_outputStream.str(""); 136 136 m_layoutTestController = LayoutTestController::create(); 137 m_gcController = GCController::create(); 137 138 WKBundleSetShouldTrackVisitedLinks(m_bundle, false); 138 139 WKBundleRemoveAllVisitedLinks(m_bundle); 139 140 m_mainPage->reset(); 140 }141 142 void InjectedBundle::setShouldTrackVisitedLinks()143 {144 WKBundleSetShouldTrackVisitedLinks(m_bundle, true);145 141 } 146 142 -
trunk/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
r64485 r64921 27 27 #define InjectedBundle_h 28 28 29 #include "GCController.h" 29 30 #include "LayoutTestController.h" 30 31 #include <WebKit2/WKBase.h> … … 47 48 void initialize(WKBundleRef); 48 49 49 void done();50 WKBundleRef bundle() const { return m_bundle; } 50 51 51 52 LayoutTestController* layoutTestController() { return m_layoutTestController.get(); } 53 GCController* gcController() { return m_gcController.get(); } 54 52 55 InjectedBundlePage* page() { return m_mainPage.get(); } 53 56 size_t pageCount() { return !!m_mainPage + m_otherPages.size(); } 54 57 void closeOtherPages(); 55 58 59 void done(); 56 60 std::ostringstream& os() { return m_outputStream; } 57 58 void setShouldTrackVisitedLinks();59 61 60 62 private: … … 77 79 78 80 RefPtr<LayoutTestController> m_layoutTestController; 81 RefPtr<GCController> m_gcController; 79 82 80 83 std::ostringstream m_outputStream; -
trunk/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
r64576 r64921 329 329 JSValueRef exception = 0; 330 330 InjectedBundle::shared().layoutTestController()->makeWindowObject(context, window, &exception); 331 InjectedBundle::shared().gcController()->makeWindowObject(context, window, &exception); 331 332 } 332 333 -
trunk/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
r64576 r64921 33 33 #include <WebKit2/WKBundleFramePrivate.h> 34 34 #include <WebKit2/WKBundlePagePrivate.h> 35 #include <WebKit2/WKBundlePrivate.h> 35 36 #include <WebKit2/WKRetainPtr.h> 36 37 #include <WebKit2/WebKit2.h> … … 41 42 // Eventually it should be changed to match. 42 43 static const CFTimeInterval waitToDumpWatchdogInterval = 6.0; 43 44 static void setProperty(JSContextRef context, JSObjectRef object, const char* propertyName, JSWrappable* value, JSPropertyAttributes attributes, JSValueRef* exception)45 {46 JSRetainPtr<JSStringRef> propertyNameString(Adopt, JSStringCreateWithUTF8CString(propertyName));47 JSObjectSetProperty(context, object, propertyNameString.get(), JSWrapper::wrap(context, value), attributes, exception);48 }49 44 50 45 static JSValueRef propertyValue(JSContextRef context, JSObjectRef object, const char* propertyName) … … 170 165 void LayoutTestController::keepWebHistory() 171 166 { 172 InjectedBundle::shared().setShouldTrackVisitedLinks();167 WKBundleSetShouldTrackVisitedLinks(InjectedBundle::shared().bundle(), true); 173 168 } 174 169 -
trunk/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
r64485 r64921 28 28 29 29 #include "JSWrappable.h" 30 #include <JavaScriptCore/JavaScriptCore.h>31 30 #include <JavaScriptCore/JSRetainPtr.h> 32 31 #include <wtf/PassRefPtr.h> -
trunk/WebKitTools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
r64576 r64921 34 34 6510A78C11EC643800410867 /* WebKitWeightWatcher900.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 6510A78111EC643800410867 /* WebKitWeightWatcher900.ttf */; }; 35 35 65EB85A011EC67CC0034D300 /* ActivateFonts.mm in Sources */ = {isa = PBXBuildFile; fileRef = 65EB859F11EC67CC0034D300 /* ActivateFonts.mm */; }; 36 BC14E4DB120E02D000826C0C /* GCController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC14E4D9120E02D000826C0C /* GCController.cpp */; }; 37 BC14E4EA120E03D800826C0C /* JSGCController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC14E4E8120E03D800826C0C /* JSGCController.cpp */; }; 36 38 BC25193E11D15D8B002EBC01 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BC7934A411906584005EA8E2 /* Cocoa.framework */; }; 37 39 BC25193F11D15D8B002EBC01 /* WebKit2.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BC7934AB1190658C005EA8E2 /* WebKit2.framework */; }; … … 86 88 65EB859F11EC67CC0034D300 /* ActivateFonts.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ActivateFonts.mm; sourceTree = "<group>"; }; 87 89 8DD76FA10486AA7600D96B5E /* WebKitTestRunner */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = WebKitTestRunner; sourceTree = BUILT_PRODUCTS_DIR; }; 90 BC14E4D8120E02D000826C0C /* GCController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GCController.h; sourceTree = "<group>"; }; 91 BC14E4D9120E02D000826C0C /* GCController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GCController.cpp; sourceTree = "<group>"; }; 92 BC14E4E1120E032000826C0C /* GCController.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = GCController.idl; sourceTree = "<group>"; }; 93 BC14E4E8120E03D800826C0C /* JSGCController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSGCController.cpp; path = ../../WebKitBuild/Debug/DerivedSources/WebKitTestRunner/JSGCController.cpp; sourceTree = SOURCE_ROOT; }; 94 BC14E4E9120E03D800826C0C /* JSGCController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSGCController.h; path = ../../WebKitBuild/Debug/DerivedSources/WebKitTestRunner/JSGCController.h; sourceTree = SOURCE_ROOT; }; 88 95 BC25184611D15767002EBC01 /* InjectedBundleMain.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InjectedBundleMain.cpp; sourceTree = "<group>"; }; 89 96 BC25186211D15D54002EBC01 /* InjectedBundle.bundle */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = InjectedBundle.bundle; sourceTree = BUILT_PRODUCTS_DIR; }; … … 203 210 sourceTree = "<group>"; 204 211 }; 212 BC14E4E0120E02F900826C0C /* Controllers */ = { 213 isa = PBXGroup; 214 children = ( 215 BC14E4D9120E02D000826C0C /* GCController.cpp */, 216 BC14E4D8120E02D000826C0C /* GCController.h */, 217 BCC9981711D3F51E0017BCA2 /* LayoutTestController.cpp */, 218 BCC9981611D3F51E0017BCA2 /* LayoutTestController.h */, 219 ); 220 name = Controllers; 221 sourceTree = "<group>"; 222 }; 205 223 BC25183511D1571D002EBC01 /* InjectedBundle */ = { 206 224 isa = PBXGroup; … … 208 226 BC952D3A11F3BF1F003398B4 /* Derived Sources */, 209 227 BC952C0A11F3B939003398B4 /* Bindings */, 228 BC14E4E0120E02F900826C0C /* Controllers */, 210 229 65EB859E11EC67CC0034D300 /* mac */, 211 230 65EB859D11EC67CC0034D300 /* ActivateFonts.h */, … … 215 234 BCC997A211D3C8F60017BCA2 /* InjectedBundlePage.cpp */, 216 235 BCC997A311D3C8F60017BCA2 /* InjectedBundlePage.h */, 217 BCC9981711D3F51E0017BCA2 /* LayoutTestController.cpp */,218 BCC9981611D3F51E0017BCA2 /* LayoutTestController.h */,219 236 ); 220 237 path = InjectedBundle; … … 269 286 BC952C0C11F3B965003398B4 /* JSWrapper.cpp */, 270 287 BC952C0B11F3B965003398B4 /* JSWrapper.h */, 288 BC14E4E1120E032000826C0C /* GCController.idl */, 271 289 BC952ED211F3C29F003398B4 /* LayoutTestController.idl */, 272 290 ); … … 277 295 isa = PBXGroup; 278 296 children = ( 297 BC14E4E8120E03D800826C0C /* JSGCController.cpp */, 298 BC14E4E9120E03D800826C0C /* JSGCController.h */, 279 299 BC952F1D11F3C652003398B4 /* JSLayoutTestController.cpp */, 280 300 BC952F1E11F3C652003398B4 /* JSLayoutTestController.h */, … … 412 432 BC952C0D11F3B965003398B4 /* JSWrapper.cpp in Sources */, 413 433 BC952F1F11F3C652003398B4 /* JSLayoutTestController.cpp in Sources */, 434 BC14E4DB120E02D000826C0C /* GCController.cpp in Sources */, 435 BC14E4EA120E03D800826C0C /* JSGCController.cpp in Sources */, 414 436 ); 415 437 runOnlyForDeploymentPostprocessing = 0; -
trunk/WebKitTools/WebKitTestRunner/win/InjectedBundle.vcproj
r64500 r64921 289 289 > 290 290 <File 291 RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSGCController.cpp" 292 > 293 </File> 294 <File 295 RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSGCController.h" 296 > 297 </File> 298 <File 291 299 RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSLayoutTestController.cpp" 292 300 > … … 319 327 <File 320 328 RelativePath="..\InjectedBundle\InjectedBundlePage.h" 329 > 330 </File> 331 <File 332 RelativePath="..\InjectedBundle\GCController.cpp" 333 > 334 </File> 335 <File 336 RelativePath="..\InjectedBundle\GCController.h" 321 337 > 322 338 </File>
Note: See TracChangeset
for help on using the changeset viewer.