Changeset 64995 in webkit

Timestamp:

Aug 9, 2010 11:33:03 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

EWS bots wait 2 minutes between patches
​https://bugs.webkit.org/show_bug.cgi?id=43731

• Scripts/webkitpy/tool/bot/queueengine.py:
  • Don't sleep after failures. This was a hold-over from an earlier design.
• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • EWS bots were not properly reporting true/false from process_work_item. They were always returning None, thus false, thus always logging as a failure and sleeping 2 minutes after each patch.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/queueengine.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-08-09  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        EWS bots wait 2 minutes between patches
+        https://bugs.webkit.org/show_bug.cgi?id=43731
+
+        * Scripts/webkitpy/tool/bot/queueengine.py:
+         - Don't sleep after failures.  This was a hold-over from
+           an earlier design.
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+         - EWS bots were not properly reporting true/false from process_work_item.
+           They were always returning None, thus false, thus always logging
+           as a failure and sleeping 2 minutes after each patch.
+
 2010-08-09  Sam Weinig  <sam@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/tool/bot/queueengine.py

@@ -108 +108 @@
                 try:
                     if not self._delegate.process_work_item(work_item):
-                        self._sleep("Unable to process work item.")
+                        log("Unable to process work item.")
+                        continue
                 except ScriptError, e:
                     # Use a special exit code to indicate that the error was already

trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

@@ -153 +153 @@
         if not self._committers.committer_by_email(patch.attacher_email()):
             self._did_error(patch, "%s cannot process patches from non-committers :(" % self.name)
-            return
-        AbstractEarlyWarningSystem.process_work_item(self, patch)
+            return False
+        return AbstractEarlyWarningSystem.process_work_item(self, patch)