Changeset 65126 in webkit

Timestamp:

Aug 10, 2010 11:19:23 PM (14 years ago)

Author:

dpranke@chromium.org

Message:

2010-08-10 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

webkit-patch should refuse to run under Win32 Python
​https://bugs.webkit.org/show_bug.cgi?id=40962

Given that there are lots of places in webkit-patch's code that
assume unix-style filenames (forward slashes), webkit-patch fails
with weird file-not-found errors when run under a native windows
Python. It would be nice if we just trapped this and errored out
at the beginning, rather than producing unpredictable errors.

• Scripts/webkit-patch:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkit-patch (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-08-10  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        webkit-patch should refuse to run under Win32 Python
+        https://bugs.webkit.org/show_bug.cgi?id=40962
+
+        Given that there are lots of places in webkit-patch's code that
+        assume unix-style filenames (forward slashes), webkit-patch fails
+        with weird file-not-found errors when run under a native windows
+        Python. It would be nice if we just trapped this and errored out
+        at the beginning, rather than producing unpredictable errors.
+
+        * Scripts/webkit-patch:
+
 2010-08-10  Kent Tamura  <tkent@chromium.org>
 

trunk/WebKitTools/Scripts/webkit-patch

@@ -39 +39 @@
 import webkitpy.python24.versioning as versioning
 
+_log = logging.getLogger("webkit-patch")
 
 def main():
@@ -51 +52 @@
 
     versioning.check_version()
+    
+    if sys.platform == "win32":
+        _log.fatal("webkit-patch is only supported under Cygwin Python, "
+                   "not Win32 Python")
+        sys.exit(1)
 
     # Import webkit-patch code only after version-checking so that