Changeset 65179 in webkit
- Timestamp:
- Aug 11, 2010 12:55:37 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r65176 r65179 1 2010-08-11 Daniel Bates <dbates@rim.com> 2 3 Reviewed by Darin Adler. 4 5 Perl warnings when running commit-log-editor 6 https://bugs.webkit.org/show_bug.cgi?id=43856 7 8 Fixes Perl warnings introduced by the patch for Bug #40548. 9 10 Perl doesn't have symbolic names for True/False. Instead, we 11 should use boolean values. Moreover, the variable installedEditorApplication 12 is not be used and should be renamed builtEditorApplication so that it 13 uses the existing machinery to set the commit log editor application. 14 15 * Scripts/commit-log-editor: 16 1 17 2010-08-11 Adam Barth <abarth@webkit.org> 2 18 -
trunk/WebKitTools/Scripts/commit-log-editor
r65148 r65179 66 66 $editor = "" if isCommitLogEditor($editor); 67 67 68 my $splitEditor = true;68 my $splitEditor = 1; 69 69 if (!$editor) { 70 70 my $builtEditorApplication = "$baseDir/Release/Commit Log Editor.app/Contents/MacOS/Commit Log Editor"; 71 71 if (-x $builtEditorApplication) { 72 72 $editor = $builtEditorApplication; 73 $splitEditor = false;73 $splitEditor = 0; 74 74 } 75 75 } … … 78 78 if (-x $builtEditorApplication) { 79 79 $editor = $builtEditorApplication; 80 $splitEditor = false;80 $splitEditor = 0; 81 81 } 82 82 } 83 83 if (!$editor) { 84 my $ installedEditorApplication = "$ENV{HOME}/Applications/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";84 my $builtEditorApplication = "$ENV{HOME}/Applications/Commit Log Editor.app/Contents/MacOS/Commit Log Editor"; 85 85 if (-x $builtEditorApplication) { 86 86 $editor = $builtEditorApplication; 87 $splitEditor = false;87 $splitEditor = 0; 88 88 } 89 89 }
Note: See TracChangeset
for help on using the changeset viewer.