Changeset 65179 in webkit


Ignore:
Timestamp:
Aug 11, 2010 12:55:37 PM (14 years ago)
Author:
dbates@webkit.org
Message:

2010-08-11 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Perl warnings when running commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=43856

Fixes Perl warnings introduced by the patch for Bug #40548.

Perl doesn't have symbolic names for True/False. Instead, we
should use boolean values. Moreover, the variable installedEditorApplication
is not be used and should be renamed builtEditorApplication so that it
uses the existing machinery to set the commit log editor application.

  • Scripts/commit-log-editor:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r65176 r65179  
     12010-08-11  Daniel Bates  <dbates@rim.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Perl warnings when running commit-log-editor
     6        https://bugs.webkit.org/show_bug.cgi?id=43856
     7
     8        Fixes Perl warnings introduced by the patch for Bug #40548.
     9
     10        Perl doesn't have symbolic names for True/False. Instead, we
     11        should use boolean values. Moreover, the variable installedEditorApplication
     12        is not be used and should be renamed builtEditorApplication so that it
     13        uses the existing machinery to set the commit log editor application.
     14
     15        * Scripts/commit-log-editor:
     16
    1172010-08-11  Adam Barth  <abarth@webkit.org>
    218
  • trunk/WebKitTools/Scripts/commit-log-editor

    r65148 r65179  
    6666$editor = "" if isCommitLogEditor($editor);
    6767
    68 my $splitEditor = true;
     68my $splitEditor = 1;
    6969if (!$editor) {
    7070    my $builtEditorApplication = "$baseDir/Release/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
    7171    if (-x $builtEditorApplication) {
    7272        $editor = $builtEditorApplication;
    73         $splitEditor = false;
     73        $splitEditor = 0;
    7474    }
    7575}
     
    7878    if (-x $builtEditorApplication) {
    7979        $editor = $builtEditorApplication;
    80         $splitEditor = false;
     80        $splitEditor = 0;
    8181    }
    8282}
    8383if (!$editor) {
    84     my $installedEditorApplication = "$ENV{HOME}/Applications/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
     84    my $builtEditorApplication = "$ENV{HOME}/Applications/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
    8585    if (-x $builtEditorApplication) {
    8686        $editor = $builtEditorApplication;
    87         $splitEditor = false;
     87        $splitEditor = 0;
    8888    }
    8989}
Note: See TracChangeset for help on using the changeset viewer.