Changeset 65264 in webkit

Timestamp:

Aug 12, 2010 1:28:18 PM (14 years ago)

Author:

Csaba Osztrogonác

Message:

2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

[Qt] Fix warnings: unknown conversion type character 'l' in format
​https://bugs.webkit.org/show_bug.cgi?id=43359

Qt port doesn't call any printf in String::format(...), consequently
using attribute((format(printf,m,n))) is incorrect and causes
false positive warnings on Windows if you build with MinGW.

Qt port calls QString::vsprintf(...) , which is platform
independent, and handles %lli, %llu and %llx on all platforms.
(​http://trac.webkit.org/changeset/35712)

• wtf/text/WTFString.h:

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/WTFString.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-08-12  Csaba Osztrogonác  <ossy@webkit.org>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] Fix warnings: unknown conversion type character 'l' in format
+        https://bugs.webkit.org/show_bug.cgi?id=43359
+
+        Qt port doesn't call any printf in String::format(...), consequently
+        using __attribute__((format(printf,m,n))) is incorrect and causes
+        false positive warnings on Windows if you build with MinGW.
+
+        Qt port calls QString::vsprintf(...) , which is platform
+        independent, and handles %lli, %llu and %llx on all platforms.
+        (http://trac.webkit.org/changeset/35712)
+
+        * wtf/text/WTFString.h:
+
 2010-08-12  Gabor Loki  <loki@webkit.org>
 

trunk/JavaScriptCore/wtf/text/WTFString.h

@@ -202 +202 @@
     static String number(unsigned long long);
     static String number(double);
-    
+
+#if !PLATFORM(QT)
     static String format(const char *, ...) WTF_ATTRIBUTE_PRINTF(1, 2);
+#else
+    static String format(const char *, ...);
+#endif
 
     // Returns an uninitialized string. The characters needs to be written