Changeset 65396 in webkit

Timestamp:

Aug 16, 2010 1:04:17 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-08-16 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

HTML5 fragment parsing doesn't load iframes
​https://bugs.webkit.org/show_bug.cgi?id=44038

Test that iframes created in detached documents actually get loaded
when they're adopted into attached documents (or, rather, when they're
inserted into the DOM).

• fast/frames/adopt-from-created-document-expected.txt: Added.
• fast/frames/adopt-from-created-document.html: Added.

2010-08-16 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

HTML5 fragment parsing doesn't load iframes
​https://bugs.webkit.org/show_bug.cgi?id=44038

Previously, this code assumed that every source iframe was actually
attached to a render tree. It tried to "keep the iframe alive" as it
moved documents. However, if the iframe wasn't attached to begin with,
it was never "alive," so trying to keep a dead iframe alive lead to a
... zombie iframe.

Test: fast/frames/adopt-from-created-document.html

• dom/Document.cpp: (WebCore::Document::adoptNode):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/frames/adopt-from-created-document-expected.txt (added)
• LayoutTests/fast/frames/adopt-from-created-document.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        HTML5 fragment parsing doesn't load iframes
+        https://bugs.webkit.org/show_bug.cgi?id=44038
+
+        Test that iframes created in detached documents actually get loaded
+        when they're adopted into attached documents (or, rather, when they're
+        inserted into the DOM).
+
+        * fast/frames/adopt-from-created-document-expected.txt: Added.
+        * fast/frames/adopt-from-created-document.html: Added.
+
 2010-08-13  MORITA Hajime  <morrita@google.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        HTML5 fragment parsing doesn't load iframes
+        https://bugs.webkit.org/show_bug.cgi?id=44038
+
+        Previously, this code assumed that every source iframe was actually
+        attached to a render tree.  It tried to "keep the iframe alive" as it
+        moved documents.  However, if the iframe wasn't attached to begin with,
+        it was never "alive," so trying to keep a dead iframe alive lead to a
+        ...  zombie iframe.
+
+        Test: fast/frames/adopt-from-created-document.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::adoptNode):
+
 2010-08-13  MORITA Hajime  <morrita@google.com>
 

trunk/WebCore/dom/Document.cpp

@@ -831 +831 @@
     default:
         if (source->hasTagName(iframeTag))
-            static_cast<HTMLIFrameElement*>(source.get())->setRemainsAliveOnRemovalFromTree(attached());
+            static_cast<HTMLIFrameElement*>(source.get())->setRemainsAliveOnRemovalFromTree(attached() && source->attached());
 
         if (source->parentNode())