Changeset 65632 in webkit


Ignore:
Timestamp:
Aug 18, 2010 2:45:53 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-08-18 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

NOT_REACHED is reachable in SVGLength
​https://bugs.webkit.org/show_bug.cgi?id=44150

The author of this code was confused. This code is reachable. We just
haven't implemented it yet.

  • svg/SVGLength.cpp: (WebCore::SVGLength::setValue):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r65631 r65632  
     12010-08-18  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by David Levin.
     4
     5        NOT_REACHED is reachable in SVGLength
     6        https://bugs.webkit.org/show_bug.cgi?id=44150
     7
     8        The author of this code was confused.  This code is reachable.  We just
     9        haven't implemented it yet.
     10
     11        * svg/SVGLength.cpp:
     12        (WebCore::SVGLength::setValue):
     13
    1142010-08-18  Balazs Kelemen  <kb@inf.u-szeged.hu>
    215

  • trunk/WebCore/svg/SVGLength.cpp

    r64945 r65632  
    2828#include "FloatConversion.h"
    2929#include "FrameView.h"
     30#include "NotImplemented.h"
    3031#include "RenderObject.h"
    3132#include "RenderView.h"
    … …  
    204205    case LengthTypeEMS:
    205206    case LengthTypeEXS:
    206         ASSERT_NOT_REACHED();
     207        notImplemented();
    207208        break;
    208209    case LengthTypePX:
Note: See TracChangeset for help on using the changeset viewer.