Changeset 65755 in webkit


Ignore:
Timestamp:
Aug 20, 2010 2:54:16 PM (14 years ago)
Author:
dumi@chromium.org
Message:

WebCore: Removing an incorrect ASSERT.
https://bugs.webkit.org/show_bug.cgi?id=44151

Reviewed by Adam Barth.

A failure in the preflight step of a transaction wrapper does not
guarantee that the transaction is rolled back (and it shouldn't).

Test: storage/change-version-no-crash-on-preflight-failure.html

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):

LayoutTests: Check that a failure in the preflight step of a transaction wrapper does not trigger any assertion.
https://bugs.webkit.org/show_bug.cgi?id=44151

Reviewed by Adam Barth.

  • storage/change-version-no-crash-on-preflight-failure-expected.txt: Added.
  • storage/change-version-no-crash-on-preflight-failure.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r65752 r65755  
     12010-08-20  Dumitru Daniliuc  <dumi@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Check that a failure in the preflight step of a transaction wrapper does not trigger any assertion.
     6        https://bugs.webkit.org/show_bug.cgi?id=44151
     7
     8        * storage/change-version-no-crash-on-preflight-failure-expected.txt: Added.
     9        * storage/change-version-no-crash-on-preflight-failure.html: Added.
     10
    1112010-08-20  John Gregg  <johnnyg@google.com>
    212
  • trunk/WebCore/ChangeLog

    r65754 r65755  
     12010-08-20  Dumitru Daniliuc  <dumi@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Removing an incorrect ASSERT.
     6        https://bugs.webkit.org/show_bug.cgi?id=44151
     7
     8        A failure in the preflight step of a transaction wrapper does not
     9        guarantee that the transaction is rolled back (and it shouldn't).
     10
     11        Test: storage/change-version-no-crash-on-preflight-failure.html
     12
     13        * storage/SQLTransaction.cpp:
     14        (WebCore::SQLTransaction::openTransactionAndPreflight):
     15
    1162010-08-20  David Leong  <david.leong@nokia.com>
    217
  • trunk/WebCore/storage/SQLTransaction.cpp

    r64537 r65755  
    274274    // Transaction Steps 3 - Peform preflight steps, jumping to the error callback if they fail
    275275    if (m_wrapper && !m_wrapper->performPreflight(this)) {
    276         ASSERT(!m_database->sqliteDatabase().transactionInProgress());
    277276        m_sqliteTransaction.clear();
    278277        m_transactionError = m_wrapper->sqlError();
Note: See TracChangeset for help on using the changeset viewer.