Changeset 65966 in webkit

Timestamp:

Aug 24, 2010 7:59:44 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix 28 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44574

• platform/chromium/drt_expectations.txt:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix 28 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44574

Reset DevToolsClient and DevToolsAgent before closing a DevTools
WebView in order to avoid accessing to a deleted WebView instance.

• DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeDevTools):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/drt_expectations.txt (modified) (2 diffs)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/chromium/TestShell.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-24  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [DRT/Chromium] Fix 28 inspector test crashes
+        https://bugs.webkit.org/show_bug.cgi?id=44574
+
+        * platform/chromium/drt_expectations.txt:
+
 2010-08-24  Ojan Vafai  <ojan@chromium.org>
 

trunk/LayoutTests/platform/chromium/drt_expectations.txt

@@ -209 +209 @@
 // Need to implement something?
 BUG_DRT WIN : http/tests/inspector-enabled/console-log-before-frame-navigation.html = CRASH
-BUG_DRT WIN : http/tests/inspector/change-iframe-src.html = CRASH
 BUG_DRT WIN : http/tests/inspector/console-resource-errors.html = CRASH
-BUG_DRT WIN : http/tests/inspector/console-xhr-logging.html = CRASH
 BUG_DRT WIN : http/tests/inspector/inspect-iframe-from-different-domain.html = CRASH
-BUG_DRT WIN : http/tests/inspector/resource-har-conversion.html = CRASH
 BUG_DRT WIN : http/tests/inspector/resource-parameters.html = CRASH
-BUG_DRT WIN : inspector/audits-panel-functional.html = CRASH
 BUG_DRT WIN : inspector/console-assert.html = CRASH
-BUG_DRT WIN : inspector/console-clear.html = CRASH
 BUG_DRT WIN : inspector/console-command-clear.html = CRASH
-BUG_DRT WIN : inspector/console-dir-global.html = CRASH
 BUG_DRT WIN : inspector/console-dir.html = CRASH
-BUG_DRT WIN : inspector/console-dirxml.html = CRASH
 BUG_DRT WIN : inspector/console-eval-global.html = CRASH
-BUG_DRT WIN : inspector/console-eval.html = CRASH
 BUG_DRT WIN : inspector/console-format-collections.html = CRASH
-BUG_DRT WIN : inspector/console-format.html = CRASH
 BUG_DRT WIN : inspector/console-log-before-inspector-open.html = CRASH
-BUG_DRT WIN : inspector/console-log-syntax-error.html = CRASH
 BUG_DRT WIN : inspector/console-tests.html = CRASH
-BUG_DRT WIN : inspector/console-trace.html = CRASH
 BUG_DRT WIN : inspector/cookie-resource-match.html = CRASH
-BUG_DRT WIN : inspector/debugger-breakpoints-not-activated-on-reload.html = CRASH
 BUG_DRT WIN : inspector/debugger-eval-while-paused.html = CRASH
 BUG_DRT WIN : inspector/debugger-no-nested-pause.html = CRASH
@@ -241 +229 @@
 BUG_DRT WIN : inspector/debugger-step-over.html = CRASH
 BUG_DRT WIN : inspector/dom-breakpoints.html = CRASH
-BUG_DRT WIN : inspector/elements-img-tooltip.html = CRASH
 BUG_DRT WIN : inspector/elements-panel-limited-children.html = CRASH
-BUG_DRT WIN : inspector/elements-panel-rewrite-href.html = CRASH
 BUG_DRT WIN : inspector/elements-panel-search.html = CRASH
-BUG_DRT WIN : inspector/elements-panel-selection-on-refresh.html = CRASH
 BUG_DRT WIN : inspector/elements-panel-structure.html = CRASH
-BUG_DRT WIN : inspector/elements-panel-styles.html = CRASH
 BUG_DRT WIN : inspector/elements-panel-xhtml-structure.xhtml = CRASH
-BUG_DRT WIN : inspector/evaluate-in-frontend.html = CRASH
 BUG_DRT WIN : inspector/inspected-objects-not-overriden.html = CRASH
-BUG_DRT WIN : inspector/styles-computed-trace.html = CRASH
 BUG_DRT WIN : inspector/styles-disable-inherited.html = CRASH
-BUG_DRT WIN : inspector/styles-disable-then-delete.html = CRASH
 BUG_DRT WIN : inspector/styles-disable-then-enable.html = CRASH
-BUG_DRT WIN : inspector/styles-iframe.html = CRASH
 BUG_DRT WIN : inspector/styles-source-lines-inline.html = CRASH
-BUG_DRT WIN : inspector/styles-source-lines.html = CRASH
 BUG_DRT WIN : inspector/styles-source-offsets.html = CRASH
-BUG_DRT WIN : inspector/syntax-highlight-css.html = CRASH
 BUG_DRT WIN : inspector/syntax-highlight-html.html = CRASH
-BUG_DRT WIN : inspector/syntax-highlight-javascript.html = CRASH
 BUG_DRT WIN : inspector/timeline-enum-stability.html = CRASH
-BUG_DRT WIN : inspector/timeline-event-dispatch.html = CRASH
 BUG_DRT WIN : inspector/timeline-layout.html = CRASH
-BUG_DRT WIN : inspector/timeline-mark-timeline.html = CRASH
 BUG_DRT WIN : inspector/timeline-network-resource.html = CRASH
-BUG_DRT WIN : inspector/timeline-paint.html = CRASH
 BUG_DRT WIN : inspector/timeline-parse-html.html = CRASH
-BUG_DRT WIN : inspector/timeline-recalculate-styles.html = CRASH
 BUG_DRT WIN : inspector/timeline-script-tag-1.html = CRASH
-BUG_DRT WIN : inspector/timeline-script-tag-2.html = CRASH
 BUG_DRT WIN : inspector/timeline-trivial.html = CRASH
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-08-24  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [DRT/Chromium] Fix 28 inspector test crashes
+        https://bugs.webkit.org/show_bug.cgi?id=44574
+
+        Reset DevToolsClient and DevToolsAgent before closing a DevTools
+        WebView in order to avoid accessing to a deleted WebView instance.
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::closeDevTools):
+
 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/chromium/TestShell.cpp

@@ -145 +145 @@
 {
     if (m_devTools) {
+        m_drtDevToolsAgent->reset();
+        if (m_drtDevToolsClient)
+            m_drtDevToolsClient->reset();
+        m_drtDevToolsAgent->setWebView(0);
         closeWindow(m_devTools);
         m_devTools = 0;