Changeset 66217 in webkit

Timestamp:

Aug 27, 2010 6:45:03 AM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

2010-08-26 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for automatically creating new windows in QWebView
​https://bugs.webkit.org/show_bug.cgi?id=29847

Improved the documentation of createWindow methods of both QWebView and
QWebPage by mentioning that for any of them be called, QWebSettings'
JavaScriptCanOpenWindows must be set to true.

• Api/qwebpage.cpp:
• Api/qwebview.cpp:

Location:

trunk/WebKit/qt

Files:

• Api/qwebpage.cpp (modified) (1 diff)
• Api/qwebview.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/WebKit/qt/Api/qwebpage.cpp

@@ -2132 +2132 @@
     If \a type is WebModalDialog, the application must call setWindowModality(Qt::ApplicationModal) on the new window.
 
-    \sa acceptNavigationRequest()
+    \note In the cases when the window creation is being triggered by JavaScript, apart from
+    reimplementing this method application must also set the JavaScriptCanOpenWindows attribute
+    of QWebSettings to true in order to get it called.
+
+    \sa acceptNavigationRequest(), QWebView::createWindow()
 */
 QWebPage *QWebPage::createWindow(WebWindowType type)

trunk/WebKit/qt/Api/qwebview.cpp

@@ -954 +954 @@
     method is not called, unless explicitly done so in the reimplementation.
 
-    \sa QWebPage::createWindow()
+    \note In the cases when the window creation is being triggered by JavaScript, apart from
+    reimplementing this method application must also set the JavaScriptCanOpenWindows attribute
+    of QWebSettings to true in order to get it called..
+
+    \sa QWebPage::createWindow(), QWebPage::acceptNavigationRequest()
 */
 QWebView *QWebView::createWindow(QWebPage::WebWindowType type)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-08-26  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Add support for automatically creating new windows in QWebView
+        https://bugs.webkit.org/show_bug.cgi?id=29847
+
+        Improved the documentation of createWindow methods of both QWebView and
+        QWebPage by mentioning that for any of them be called, QWebSettings'
+        JavaScriptCanOpenWindows attribute must be set to true.
+
+        * Api/qwebpage.cpp:
+        * Api/qwebview.cpp:
+
 2010-08-27  Yury Semikhatsky  <yurys@chromium.org>