Changeset 66280 in webkit

Timestamp:

Aug 27, 2010 4:59:06 PM (14 years ago)

Author:

kinuko@chromium.org

Message:

2010-08-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[chromium] Add chromium-side of AsyncFileSystem implementation
​https://bugs.webkit.org/show_bug.cgi?id=44434

• WebKit.gyp:
• src/AssertMatchingEnums.cpp: Added assertions.
• src/AsyncFileSystemChromium.cpp: Added.
• src/AsyncFileSystemChromium.h: Added.
• src/LocalFileSystemChromium.cpp: Added.
• src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
• src/WebFileSystemCallbacksImpl.h:

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• WebKit.gyp (modified) (2 diffs)
• src/AssertMatchingEnums.cpp (modified) (3 diffs)
• src/AsyncFileSystemChromium.cpp (added)
• src/AsyncFileSystemChromium.h (added)
• src/LocalFileSystemChromium.cpp (added)
• src/WebFileSystemCallbacksImpl.cpp (modified) (3 diffs)
• src/WebFileSystemCallbacksImpl.h (modified) (3 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-08-27  Kinuko Yasuda  <kinuko@chromium.org>
+
+        Reviewed by Dumitru Daniliuc.
+
+        [chromium] Add chromium-side of AsyncFileSystem implementation
+        https://bugs.webkit.org/show_bug.cgi?id=44434
+
+        * WebKit.gyp:
+        * src/AssertMatchingEnums.cpp: Added assertions.
+        * src/AsyncFileSystemChromium.cpp: Added.
+        * src/AsyncFileSystemChromium.h: Added.
+        * src/LocalFileSystemChromium.cpp: Added.
+        * src/WebFileSystemCallbacksImpl.cpp:
+        (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
+        * src/WebFileSystemCallbacksImpl.h:
+
 2010-08-27  Michael Nordman  <michaeln@google.com>
 

trunk/WebKit/chromium/WebKit.gyp

@@ -293 +293 @@
                 'src/ApplicationCacheHostInternal.h',
                 'src/AssertMatchingEnums.cpp',
+                'src/AsyncFileSystemChromium.cpp',
+                'src/AsyncFileSystemChromium.h',
                 'src/AutoFillPopupMenuClient.cpp',
                 'src/AutoFillPopupMenuClient.h',
@@ -364 +366 @@
                 'src/mac/WebInputEventFactory.mm',
                 'src/mac/WebScreenInfoFactory.mm',
+                'src/LocalFileSystemChromium.cpp',
                 'src/LocalizedStrings.cpp',
                 'src/MediaPlayerPrivateChromium.cpp',

trunk/WebKit/chromium/src/AssertMatchingEnums.cpp

@@ -36 +36 @@
 #include "AccessibilityObject.h"
 #include "ApplicationCacheHost.h"
+#include "AsyncFileSystem.h"
 #include "EditorInsertAction.h"
 #include "FontDescription.h"
@@ -55 +56 @@
 #include "WebCursorInfo.h"
 #include "WebEditingAction.h"
+#include "WebFileSystem.h"
 #include "WebFontDescription.h"
 #include "WebIDBKey.h"
@@ -381 +383 @@
 COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::StringType, IDBKey::StringType);
 COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::NumberType, IDBKey::NumberType);
+
+#if ENABLE(FILE_SYSTEM)
+COMPILE_ASSERT_MATCHING_ENUM(WebFileSystem::TypeTemporary, AsyncFileSystem::Temporary);
+COMPILE_ASSERT_MATCHING_ENUM(WebFileSystem::TypePersistent, AsyncFileSystem::Persistent);
+#endif

trunk/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp

@@ -33 +33 @@
 #if ENABLE(FILE_SYSTEM)
 
+#include "AsyncFileSystemCallbacks.h"
+#include "AsyncFileSystemChromium.h"
 #include "ExceptionCode.h"
-#include "FileSystemCallbacks.h"
 #include "WebFileSystemEntry.h"
 #include "WebFileInfo.h"
@@ -44 +45 @@
 namespace WebKit {
 
-WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl(PassOwnPtr<FileSystemCallbacksBase> callbacks)
+WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl(PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
     : m_callbacks(callbacks)
 {
@@ -79 +80 @@
 void WebFileSystemCallbacksImpl::didOpenFileSystem(const WebString& name, const WebString& path)
 {
-    m_callbacks->didOpenFileSystem(name, path);
+    m_callbacks->didOpenFileSystem(name, new AsyncFileSystemChromium(path));
     delete this;
 }

trunk/WebKit/chromium/src/WebFileSystemCallbacksImpl.h

@@ -38 +38 @@
 
 namespace WebCore {
-class FileSystemCallbacksBase;
+class AsyncFileSystemCallbacks;
 }
 
@@ -49 +49 @@
 class WebFileSystemCallbacksImpl : public WebFileSystemCallbacks {
 public:
-    WebFileSystemCallbacksImpl(PassOwnPtr<WebCore::FileSystemCallbacksBase>);
+    WebFileSystemCallbacksImpl(PassOwnPtr<WebCore::AsyncFileSystemCallbacks>);
     virtual ~WebFileSystemCallbacksImpl();
 
@@ -59 +59 @@
 
 private:
-    OwnPtr<WebCore::FileSystemCallbacksBase> m_callbacks;
+    OwnPtr<WebCore::AsyncFileSystemCallbacks> m_callbacks;
 };