Changeset 66495 in webkit


Ignore:
Timestamp:
Aug 31, 2010 10:01:22 AM (14 years ago)
Author:
Csaba Osztrogonác
Message:

2010-08-31 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

[Qt] Fix warnings in WebKit2 directory
https://bugs.webkit.org/show_bug.cgi?id=44593

  • Platform/CoreIPC/qt/ConnectionQt.cpp: Mark unused variables for compiler. (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
  • Shared/qt/WebEventFactoryQt.cpp: (WebKit::WebEventFactory::createWebTouchEvent): Initialize state variable. Default case added.
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: (WebKit::toNP): Return initialized NPEvent.
Location:
trunk/WebKit2
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit2/ChangeLog

    r66493 r66495  
     12010-08-31  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        [Qt] Fix warnings in WebKit2 directory
     6        https://bugs.webkit.org/show_bug.cgi?id=44593
     7
     8        * Platform/CoreIPC/qt/ConnectionQt.cpp: Mark unused variables for compiler.
     9        (CoreIPC::Connection::readyReadHandler):
     10        (CoreIPC::Connection::sendOutgoingMessage):
     11        * Shared/qt/WebEventFactoryQt.cpp:
     12        (WebKit::WebEventFactory::createWebTouchEvent): Initialize state variable. Default case added.
     13        * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
     14        (WebKit::toNP): Return initialized NPEvent.
     15
    1162010-08-31  Andras Becsi  <abecsi@webkit.org>
    217
  • trunk/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp

    r64628 r66495  
    6060        if (!m_currentMessageSize) {
    6161            size_t numberOfBytesRead = m_socket->read(reinterpret_cast<char*>(m_readBuffer.data()), sizeof(size_t));
    62             ASSERT(numberOfBytesRead);
     62            ASSERT_UNUSED(numberOfBytesRead, numberOfBytesRead);
    6363            m_currentMessageSize = *reinterpret_cast<size_t*>(m_readBuffer.data());
    6464        }
     
    7272
    7373        size_t numberOfBytesRead = m_socket->read(reinterpret_cast<char*>(m_readBuffer.data()), m_currentMessageSize);
    74         ASSERT(numberOfBytesRead);
     74        ASSERT_UNUSED(numberOfBytesRead, numberOfBytesRead);
    7575
    7676        // The messageID is encoded at the end of the buffer.
     
    126126    qint64 bytesWritten = m_socket->write(reinterpret_cast<char*>(arguments->buffer()), arguments->bufferSize());
    127127
    128     ASSERT(bytesWritten == arguments->bufferSize());
     128    ASSERT_UNUSED(bytesWritten, bytesWritten == arguments->bufferSize());
    129129    return true;
    130130}
  • trunk/WebKit2/Shared/qt/WebEventFactoryQt.cpp

    r65788 r66495  
    174174{
    175175    WebEvent::Type type  = webEventTypeForEvent(event);
    176     WebPlatformTouchPoint::TouchPointState state;
     176    WebPlatformTouchPoint::TouchPointState state = static_cast<WebPlatformTouchPoint::TouchPointState>(0);
    177177    unsigned int id;
    178178    WebEvent::Modifiers modifiers   = modifiersForEvent(event->modifiers());
     
    197197            state = WebPlatformTouchPoint::TouchStationary;
    198198            break;
     199        default:
     200            ASSERT_NOT_REACHED();
     201            break;
    199202        }
    200203
  • trunk/WebKit2/WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp

    r65805 r66495  
    4848NPEvent toNP(const WebMouseEvent& event)
    4949{
    50     NPEvent npEvent;
     50    NPEvent npEvent = NPEvent();
    5151
    5252    notImplemented();
Note: See TracChangeset for help on using the changeset viewer.