Changeset 66672 in webkit


Ignore:
Timestamp:
Sep 2, 2010 9:30:09 AM (14 years ago)
Author:
caseq@chromium.org
Message:

2010-09-02 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed test fix.
Add size & bodySize to list of non-deterministic fields for HAR tests, as those tend to vary by platform
in error responses.
Remove platform-specific expectations that were previously added because of this.

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-test2.js:
  • platform/chromium-win/inspector/resource-har-conversion-expected.txt: Removed.
  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
2 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r66671 r66672  
     12010-09-02  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Unreviewed test fix.
     4        Add size & bodySize to list of non-deterministic fields for HAR tests, as those tend to vary by platform
     5        in error responses.
     6        Remove platform-specific expectations that were previously added because of this.
     7
     8        * http/tests/inspector/resource-har-conversion-expected.txt:
     9        * http/tests/inspector/resource-har-conversion.html:
     10        * http/tests/inspector/resource-test2.js:
     11        * platform/chromium-win/inspector/resource-har-conversion-expected.txt: Removed.
     12        * platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
     13
    1142010-09-02  Nate Chapin  <japhet@chromium.org>
    215

  • trunk/LayoutTests/http/tests/inspector/resource-har-conversion-expected.txt

    r66669 r66672  
    1212            headers : <object>
    1313            headersSize : -1
    14             bodySize : -1
     14            bodySize : <number>
    1515        }
    1616        response : {
    … …  
    1919            headers : <object>
    2020            content : {
    21                 size : 0
     21                size : <number>
    2222                mimeType : "application/x-javascript"
    2323            }
    2424            redirectURL : ""
    2525            headersSize : -1
    26             bodySize : 0
     26            bodySize : <number>
    2727        }
    2828        timings : {
    … …  
    4545            headers : <object>
    4646            headersSize : -1
    47             bodySize : -1
     47            bodySize : <number>
    4848        }
    4949        response : {
    … …  
    5252            headers : <object>
    5353            content : {
    54                 size : 1137
     54                size : <number>
    5555                mimeType : "text/html"
    5656            }
    5757            redirectURL : ""
    5858            headersSize : -1
    59             bodySize : 1137
     59            bodySize : <number>
    6060        }
    6161        timings : {
    … …  
    7878            headers : <object>
    7979            headersSize : -1
    80             bodySize : -1
     80            bodySize : <number>
    8181        }
    8282        response : {
    … …  
    8585            headers : <object>
    8686            content : {
    87                 size : 0
     87                size : <number>
    8888                mimeType : "application/x-javascript"
    8989            }
    9090            redirectURL : ""
    9191            headersSize : -1
    92             bodySize : 0
     92            bodySize : <number>
    9393        }
    9494        timings : {
    … …  
    111111            headers : <object>
    112112            headersSize : -1
    113             bodySize : -1
     113            bodySize : <number>
    114114            postData : {
    115115                mimeType : "text/xml"
    … …  
    122122            headers : <object>
    123123            content : {
    124                 size : 355
     124                size : <number>
    125125                mimeType : "text/html"
    126126            }
    127127            redirectURL : ""
    128128            headersSize : -1
    129             bodySize : 355
     129            bodySize : <number>
    130130        }
    131131        timings : {

  • trunk/LayoutTests/http/tests/inspector/resource-har-conversion.html

    r66669 r66672  
    1616        InjectedScriptAccess.getDefault().evaluate("doXHR()", "console", function() {
    1717            var resources = Object.keys(WebInspector.resources).map(getHAR).sort(InspectorTest.resourceURLComparer);
    18             InspectorTest.addObject(resources, InspectorTest.HARNondeterministicProperties);
     18            InspectorTest.addObject(resources, InspectorTest.HARNondeterministicPropertiesWithSize);
    1919            InspectorTest.disableResourceTracking();
    2020            InspectorTest.completeTest();

  • trunk/LayoutTests/http/tests/inspector/resource-test2.js

    r66669 r66672  
    99};
    1010
     11// addObject checks own properties only, so make a deep copy rather than use prototype.
     12
     13InspectorTest.HARNondeterministicPropertiesWithSize = JSON.parse(JSON.stringify(InspectorTest.HARNondeterministicProperties));
     14InspectorTest.HARNondeterministicPropertiesWithSize.size = 1;
     15InspectorTest.HARNondeterministicPropertiesWithSize.bodySize = 1;
     16
    1117InspectorTest.resourceURLComparer = function(r1, r2)
    1218{
Note: See TracChangeset for help on using the changeset viewer.