Changeset 66813 in webkit


Ignore:
Timestamp:
Sep 6, 2010 12:12:43 AM (14 years ago)
Author:
yurys@chromium.org
Message:

2010-08-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

Test: inspector/debugger-suspend-active-dom-objects.html

  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):

2010-08-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

  • inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
  • inspector/debugger-suspend-active-dom-objects.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r66812 r66813  
     12010-08-31  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Joseph Pecoraro.
     4
     5        Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
     6        https://bugs.webkit.org/show_bug.cgi?id=44943
     7
     8        * inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
     9        * inspector/debugger-suspend-active-dom-objects.html: Added.
     10
    1112010-09-05  Peter Kasting  <pkasting@google.com>
    212
  • trunk/WebCore/ChangeLog

    r66808 r66813  
     12010-08-31  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Joseph Pecoraro.
     4
     5        Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
     6        https://bugs.webkit.org/show_bug.cgi?id=44943
     7
     8        Test: inspector/debugger-suspend-active-dom-objects.html
     9
     10        * page/PageGroupLoadDeferrer.cpp:
     11        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
     12
    1132010-09-05  Kenneth Russell  <kbr@google.com>
    214
  • trunk/WebCore/page/PageGroupLoadDeferrer.cpp

    r64873 r66813  
    4040        Page* otherPage = *it;
    4141        if ((deferSelf || otherPage != page)) {
    42             if (!otherPage->defersLoading())
     42            if (!otherPage->defersLoading()) {
    4343                m_deferredFrames.append(otherPage->mainFrame());
    4444
    45             // This code is not logically part of load deferring, but we do not want JS code executed beneath modal
    46             // windows or sheets, which is exactly when PageGroupLoadDeferrer is used.
    47             for (Frame* frame = otherPage->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
    48                 frame->document()->suspendActiveDOMObjects();
    49                 frame->document()->asyncScriptRunner()->suspend();
     45                // This code is not logically part of load deferring, but we do not want JS code executed beneath modal
     46                // windows or sheets, which is exactly when PageGroupLoadDeferrer is used.
     47                for (Frame* frame = otherPage->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
     48                    frame->document()->suspendActiveDOMObjects();
     49                    frame->document()->asyncScriptRunner()->suspend();
     50                }
    5051            }
    5152        }
Note: See TracChangeset for help on using the changeset viewer.