Changeset 66930 in webkit

Timestamp:

Sep 7, 2010 4:34:11 PM (14 years ago)

Author:

Joseph Pecoraro

Message:

2010-09-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
​https://bugs.webkit.org/show_bug.cgi?id=45192

Testing the DOMHTMLSelectElement interface for selecting an
index in a <select> and triggering a "change" event. This also
tests for allowing multiple selections.

• platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
• platform/mac/fast/objc/dom-html-select-activate.html: Added.

2010-09-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
​https://bugs.webkit.org/show_bug.cgi?id=45192

Adds a selector on ObjCController for testing
-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
its different uses.

• DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/objc/dom-html-select-activate-expected.txt (added)
• LayoutTests/platform/mac/fast/objc/dom-html-select-activate.html (added)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/mac/ObjCController.m (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Provide a way to trigger a <select multiple> onchange event on changes
+        https://bugs.webkit.org/show_bug.cgi?id=45192
+
+        Testing the DOMHTMLSelectElement interface for selecting an
+        index in a <select> and triggering a "change" event. This also
+        tests for allowing multiple selections.
+
+        * platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
+        * platform/mac/fast/objc/dom-html-select-activate.html: Added.
+
 2010-09-07  Tony Chang  <tony@chromium.org>
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Provide a way to trigger a <select multiple> onchange event on changes
+        https://bugs.webkit.org/show_bug.cgi?id=45192
+
+        Adds a selector on ObjCController for testing
+        -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
+        its different uses.
+
+        * DumpRenderTree/mac/ObjCController.m:
+        (+[ObjCController isSelectorExcludedFromWebScript:]):
+        (+[ObjCController webScriptNameForSelector:]):
+        (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
+
 2010-09-07  James Robinson  <jamesr@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/mac/ObjCController.m

@@ -30 +30 @@
 #import "ObjCController.h"
 
+// Avoid compile error in DOMPrivate.h.
+@class NSFont;
+
 #import <JavaScriptCore/JavaScriptCore.h>
 #import <WebKit/DOMAbstractView.h>
+#import <WebKit/DOMPrivate.h>
 #import <WebKit/WebScriptObject.h>
 #import <WebKit/WebView.h>
@@ -74 +78 @@
             || aSelector == @selector(testHasWebScriptKey:)
             || aSelector == @selector(testArray)
+            || aSelector == @selector(setSelectElement:selectedIndex:allowingMultiple:)
         )
         return NO;
@@ -103 +108 @@
     if (aSelector == @selector(testArray))
         return @"testArray";
+    if (aSelector == @selector(setSelectElement:selectedIndex:allowingMultiple:))
+        return @"setSelectElementSelectedIndexAllowingMultiple";
 
     return nil;
@@ -264 +271 @@
 }
 
+#pragma mark -
+#pragma mark Testing Objective-C DOM HTML Bindings
+
+- (void)setSelectElement:(WebScriptObject *)element selectedIndex:(int)index allowingMultiple:(BOOL)allowingMultiple
+{
+    if (![element isKindOfClass:[DOMHTMLSelectElement class]])
+        return;
+
+    DOMHTMLSelectElement *select = (DOMHTMLSelectElement*)element;
+    [select _activateItemAtIndex:index allowMultipleSelection:allowingMultiple];
+}
+
 @end