Changeset 66948 in webkit

Timestamp:

Sep 7, 2010 9:02:55 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-09-07 Jan E Hanssen <​jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Added test case for Path::length()
​https://bugs.webkit.org/show_bug.cgi?id=45331

Also removed test case for Path::pointAtLength() that is now passing

• platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
• svg/dom/path-totalLength-expected.txt: Added.
• svg/dom/path-totalLength.html: Added.
• svg/dom/script-tests/path-totalLength.js: Added. (getTotalLength):

2010-09-07 Jan E Hanssen <​jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
​https://bugs.webkit.org/show_bug.cgi?id=45331

This is needed due to an adverse effect of the fix in 44061 that causes
certain paths not to be closed. This is not important for canvas paths
but it is for SVG paths, so splitting up the code in a generic (SVG)
case and one specialized for canvas.

Test: svg/dom/path-totalLength.html

• html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
• platform/graphics/Path.h: (WebCore::Path::closeCanvasSubpath):
• platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): (WebCore::Path::closeCanvasSubpath):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/svg/dom/path-pointAtLength-expected.txt (deleted)
• LayoutTests/svg/dom/path-totalLength-expected.txt (added)
• LayoutTests/svg/dom/path-totalLength.html (added)
• LayoutTests/svg/dom/script-tests/path-totalLength.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/canvas/CanvasRenderingContext2D.cpp (modified) (1 diff)
• WebCore/platform/graphics/Path.h (modified) (1 diff)
• WebCore/platform/graphics/qt/PathQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-09-07  Jan E Hanssen  <jhanssen@sencha.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Added test case for Path::length()
+        https://bugs.webkit.org/show_bug.cgi?id=45331
+
+        Also removed test case for Path::pointAtLength() that is now passing
+
+        * platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
+        * svg/dom/path-totalLength-expected.txt: Added.
+        * svg/dom/path-totalLength.html: Added.
+        * svg/dom/script-tests/path-totalLength.js: Added.
+        (getTotalLength):
+
 2010-09-07  Ojan Vafai  <ojan@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-07  Jan E Hanssen  <jhanssen@sencha.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
+        https://bugs.webkit.org/show_bug.cgi?id=45331
+
+        This is needed due to an adverse effect of the fix in 44061 that causes
+        certain paths not to be closed. This is not important for canvas paths
+        but it is for SVG paths, so splitting up the code in a generic (SVG)
+        case and one specialized for canvas.
+
+        Test: svg/dom/path-totalLength.html
+
+        * html/canvas/CanvasRenderingContext2D.cpp:
+        (WebCore::CanvasRenderingContext2D::closePath):
+        * platform/graphics/Path.h:
+        (WebCore::Path::closeCanvasSubpath):
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::Path::closeSubpath):
+        (WebCore::Path::closeCanvasSubpath):
+
 2010-09-07  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/html/canvas/CanvasRenderingContext2D.cpp

@@ -660 +660 @@
     FloatRect boundRect = m_path.boundingRect();
     if (boundRect.width() || boundRect.height())
-        m_path.closeSubpath();
+        m_path.closeCanvasSubpath();
 }
 

trunk/WebCore/platform/graphics/Path.h

@@ -134 +134 @@
         void addArcTo(const FloatPoint&, const FloatPoint&, float radius);
         void closeSubpath();
+#if PLATFORM(QT)
+        void closeCanvasSubpath();
+#else
+        void closeCanvasSubpath() { closeSubpath(); }
+#endif
 
         void addArc(const FloatPoint&, float radius, float startAngle, float endAngle, bool anticlockwise);

trunk/WebCore/platform/graphics/qt/PathQt.cpp

@@ -265 +265 @@
 void Path::closeSubpath()
 {
+    m_path.closeSubpath();
+}
+
+void Path::closeCanvasSubpath()
+{
     const int elementCount = m_path.elementCount();