Changeset 67278 in webkit

Timestamp:

Sep 10, 2010 10:21:17 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-09-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

Application cache directory should be checked before sending to the web process
​https://bugs.webkit.org/show_bug.cgi?id=45462

• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): Check the return value of m_context->applicationCacheDirectoy() to avoid sending a null string to the web process what makes it asserting.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessProxy.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
+
+        Reviewed by Andreas Kling.
+
+        Application cache directory should be checked before sending to the web process
+        https://bugs.webkit.org/show_bug.cgi?id=45462
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::WebProcessProxy): Check the return value of
+        m_context->applicationCacheDirectoy() to avoid sending a null string
+        to the web process what makes it asserting.
+
 2010-09-10  Sam Weinig  <sam@webkit.org>
 

trunk/WebKit2/UIProcess/WebProcessProxy.cpp

@@ -67 +67 @@
     // FIXME: Instead of sending three separate initialization related messages here, we should just send a
     // single "Initialize" messages with a struct that has all the needed information.
-    send(WebProcessMessage::SetApplicationCacheDirectory, 0, CoreIPC::In(m_context->applicationCacheDirectory()));
+    String applicationCacheDirectory = m_context->applicationCacheDirectory();
+    if (!applicationCacheDirectory.isEmpty())
+        send(WebProcessMessage::SetApplicationCacheDirectory, 0, CoreIPC::In(applicationCacheDirectory));
 
     // FIXME: We could instead send the bundle path as part of the arguments to process creation?